Fokko commented on code in PR #10498:
URL: https://github.com/apache/iceberg/pull/10498#discussion_r1675399047
##########
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##########
@@ -466,6 +466,16 @@ public List<Namespace> listNamespaces(Namespace namespace)
throws NoSuchNamespac
Arrays.stream(n.levels())
.limit(subNamespaceLevelLength)
.toArray(String[]::new)))
+ // exclude fuzzy matches
+ .filter(
+ n -> {
+ for (int i = 0; i < namespace.levels().length; i++) {
+ if (!n.levels()[i].equals(namespace.levels()[i])) {
Review Comment:
This was still open, and I skimmed over it. From intuition, I assume that
deduplicating is more expensive than filtering, so I pushed that down to get
this in for 1.6.0. I'll revert the change and merge this. Sorry about this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
