Re: [PR] Core: Adapt commit, scan, and snapshot stats for DVs [iceberg]

aokolnychyi commented on PR #11464: URL: https://github.com/apache/iceberg/pull/11464#issuecomment-2457575822 Thank you, @nastra! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] Core: Adapt commit, scan, and snapshot stats for DVs [iceberg]

aokolnychyi merged PR #11464: URL: https://github.com/apache/iceberg/pull/11464 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@icebe

Re: [PR] Core: Adapt commit, scan, and snapshot stats for DVs [iceberg]

aokolnychyi commented on code in PR #11464: URL: https://github.com/apache/iceberg/pull/11464#discussion_r1829518195 ## core/src/main/java/org/apache/iceberg/metrics/ScanMetricsUtil.java: ## @@ -31,7 +32,11 @@ public static void indexedDeleteFile(ScanMetrics metrics, DeleteFile

Re: [PR] Core: Adapt commit, scan, and snapshot stats for DVs [iceberg]

aokolnychyi commented on code in PR #11464: URL: https://github.com/apache/iceberg/pull/11464#discussion_r1829516877 ## core/src/test/java/org/apache/iceberg/TestSnapshotSummary.java: ## @@ -358,4 +358,66 @@ public void rewriteWithDeletesAndDuplicates() { .containsEntry

Re: [PR] Core: Adapt commit, scan, and snapshot stats for DVs [iceberg]

nastra commented on code in PR #11464: URL: https://github.com/apache/iceberg/pull/11464#discussion_r1828858604 ## core/src/test/java/org/apache/iceberg/TestSnapshotSummary.java: ## @@ -358,4 +358,66 @@ public void rewriteWithDeletesAndDuplicates() { .containsEntry(Snap

Re: [PR] Core: Adapt commit, scan, and snapshot stats for DVs [iceberg]

nastra commented on code in PR #11464: URL: https://github.com/apache/iceberg/pull/11464#discussion_r1828862857 ## core/src/main/java/org/apache/iceberg/util/ContentFileUtil.java: ## @@ -84,4 +85,8 @@ public static String referencedDataFileLocation(DeleteFile deleteFile) {

Re: [PR] Core: Adapt commit, scan, and snapshot stats for DVs [iceberg]

aokolnychyi commented on code in PR #11464: URL: https://github.com/apache/iceberg/pull/11464#discussion_r1828862437 ## core/src/test/java/org/apache/iceberg/TestSnapshotSummary.java: ## @@ -358,4 +358,66 @@ public void rewriteWithDeletesAndDuplicates() { .containsEntry

Re: [PR] Core: Adapt commit, scan, and snapshot stats for DVs [iceberg]

nastra commented on code in PR #11464: URL: https://github.com/apache/iceberg/pull/11464#discussion_r1828862345 ## core/src/main/java/org/apache/iceberg/metrics/ScanMetricsUtil.java: ## @@ -31,7 +32,11 @@ public static void indexedDeleteFile(ScanMetrics metrics, DeleteFile dele

Re: [PR] Core: Adapt commit, scan, and snapshot stats for DVs [iceberg]

nastra commented on code in PR #11464: URL: https://github.com/apache/iceberg/pull/11464#discussion_r1828855927 ## core/src/main/java/org/apache/iceberg/SnapshotSummary.java: ## @@ -283,8 +292,13 @@ void addedFile(ContentFile file) { this.addedRecords += file.recordCo

Re: [PR] Core: Adapt commit, scan, and snapshot stats for DVs [iceberg]

aokolnychyi commented on code in PR #11464: URL: https://github.com/apache/iceberg/pull/11464#discussion_r1828388869 ## core/src/main/java/org/apache/iceberg/SnapshotSummary.java: ## @@ -283,8 +292,13 @@ void addedFile(ContentFile file) { this.addedRecords += file.rec

Re: [PR] Core: Adapt commit, scan, and snapshot stats for DVs [iceberg]

aokolnychyi commented on code in PR #11464: URL: https://github.com/apache/iceberg/pull/11464#discussion_r1828388869 ## core/src/main/java/org/apache/iceberg/SnapshotSummary.java: ## @@ -283,8 +292,13 @@ void addedFile(ContentFile file) { this.addedRecords += file.rec