aokolnychyi commented on code in PR #11464:
URL: https://github.com/apache/iceberg/pull/11464#discussion_r1828388869
##########
core/src/main/java/org/apache/iceberg/SnapshotSummary.java:
##########
@@ -283,8 +292,13 @@ void addedFile(ContentFile<?> file) {
this.addedRecords += file.recordCount();
break;
case POSITION_DELETES:
+ DeleteFile deleteFile = (DeleteFile) file;
+ if (ContentFileUtil.isDV(deleteFile)) {
+ this.addedDVs += 1;
+ } else {
+ this.addedPosDeleteFiles += 1;
+ }
this.addedDeleteFiles += 1;
Review Comment:
I am treating "delete files" as a generic concept. We will continue to track
each type of delete as a delete file and will count DVs, position delete files,
and equality delete files separately. I think this is consistent and won't
require updating our manifest counts to differentiate between DVs and delete
files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
