Re: [PR] Core, Spark3.5: Fix tests failure due to timeout [iceberg]

2024-12-18 Thread via GitHub
manuzhang commented on PR #11654: URL: https://github.com/apache/iceberg/pull/11654#issuecomment-2550937162 @nastra `COMMIT_MAX_RETRY_WAIT_MS='1000'` is not useful when `COMMIT_NUM_RETRIES=4` by default. -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] Core, Spark3.5: Fix tests failure due to timeout [iceberg]

2024-12-18 Thread via GitHub
manuzhang commented on PR #11654: URL: https://github.com/apache/iceberg/pull/11654#issuecomment-2550900389 Latest test failure in https://github.com/apache/iceberg/actions/runs/12387757253/job/34578581231 ``` Caused by: org.apache.iceberg.exceptions.CommitFailedExce

Re: [PR] Core, Spark3.5: Fix tests failure due to timeout [iceberg]

2024-12-17 Thread via GitHub
nastra merged PR #11654: URL: https://github.com/apache/iceberg/pull/11654 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] Core, Spark3.5: Fix tests failure due to timeout [iceberg]

2024-12-17 Thread via GitHub
amogh-jahagirdar commented on PR #11654: URL: https://github.com/apache/iceberg/pull/11654#issuecomment-2548967150 Sounds good, >these specific tests typically took quite a long time due to exponential retries and eventually timed out Yeah this was the part I was trying to unp

Re: [PR] Core, Spark3.5: Fix tests failure due to timeout [iceberg]

2024-12-17 Thread via GitHub
nastra commented on PR #11654: URL: https://github.com/apache/iceberg/pull/11654#issuecomment-2548869093 @amogh-jahagirdar from what I saw in some local debugging is that these specific tests typically took quite a long time due to exponential retries and eventually timed out, hence this is

Re: [PR] Core, Spark3.5: Fix tests failure due to timeout [iceberg]

2024-12-17 Thread via GitHub
nastra commented on code in PR #11654: URL: https://github.com/apache/iceberg/pull/11654#discussion_r1888706113 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMerge.java: ## @@ -1609,8 +1611,14 @@ public synchronized void testMergeWithSnapsh

Re: [PR] Core, Spark3.5: Fix tests failure due to timeout [iceberg]

2024-12-17 Thread via GitHub
nastra commented on PR #11654: URL: https://github.com/apache/iceberg/pull/11654#issuecomment-2548570080 @RussellSpitzer or @amogh-jahagirdar can any of you also take a look at this please? -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Core, Spark3.5: Fix tests failure due to timeout [iceberg]

2024-12-17 Thread via GitHub
nastra commented on code in PR #11654: URL: https://github.com/apache/iceberg/pull/11654#discussion_r1888533602 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDelete.java: ## @@ -1144,6 +1146,8 @@ public synchronized void testDeleteWithSnaps

Re: [PR] Core, Spark3.5: Fix tests failure due to timeout [iceberg]

2024-12-17 Thread via GitHub
manuzhang commented on code in PR #11654: URL: https://github.com/apache/iceberg/pull/11654#discussion_r1888228702 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDelete.java: ## @@ -1144,6 +1146,8 @@ public synchronized void testDeleteWithSn

Re: [PR] Core, Spark3.5: Fix tests failure due to timeout [iceberg]

2024-12-17 Thread via GitHub
nastra commented on code in PR #11654: URL: https://github.com/apache/iceberg/pull/11654#discussion_r1888219695 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDelete.java: ## @@ -1144,6 +1146,8 @@ public synchronized void testDeleteWithSnaps

Re: [PR] Core, Spark3.5: Fix tests failure due to timeout [iceberg]

2024-12-17 Thread via GitHub
manuzhang commented on code in PR #11654: URL: https://github.com/apache/iceberg/pull/11654#discussion_r1888212930 ## core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCommits.java: ## @@ -421,7 +423,13 @@ public void testConcurrentFastAppends(@TempDir File dir) throws Exc

Re: [PR] Core, Spark3.5: Fix tests failure due to timeout [iceberg]

2024-12-17 Thread via GitHub
manuzhang commented on code in PR #11654: URL: https://github.com/apache/iceberg/pull/11654#discussion_r1888212930 ## core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCommits.java: ## @@ -421,7 +423,13 @@ public void testConcurrentFastAppends(@TempDir File dir) throws Exc

Re: [PR] Core, Spark3.5: Fix tests failure due to timeout [iceberg]

2024-12-17 Thread via GitHub
nastra commented on code in PR #11654: URL: https://github.com/apache/iceberg/pull/11654#discussion_r1888129296 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMerge.java: ## @@ -1611,6 +1612,7 @@ public synchronized void testMergeWithSnapsho

Re: [PR] Core, Spark3.5: Fix tests failure due to timeout [iceberg]

2024-12-17 Thread via GitHub
nastra commented on code in PR #11654: URL: https://github.com/apache/iceberg/pull/11654#discussion_r1888120949 ## core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCommits.java: ## @@ -421,7 +423,13 @@ public void testConcurrentFastAppends(@TempDir File dir) throws Except

Re: [PR] Core, Spark3.5: Fix tests failure due to timeout [iceberg]

2024-12-17 Thread via GitHub
nastra commented on code in PR #11654: URL: https://github.com/apache/iceberg/pull/11654#discussion_r1888105004 ## core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCommits.java: ## @@ -421,7 +423,13 @@ public void testConcurrentFastAppends(@TempDir File dir) throws Except

Re: [PR] Core, Spark3.5: Fix tests failure due to timeout [iceberg]

2024-12-17 Thread via GitHub
nastra commented on code in PR #11654: URL: https://github.com/apache/iceberg/pull/11654#discussion_r1888104196 ## core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCommits.java: ## @@ -421,7 +423,13 @@ public void testConcurrentFastAppends(@TempDir File dir) throws Except

Re: [PR] Core, Spark3.5: Fix tests failure due to timeout [iceberg]

2024-12-11 Thread via GitHub
manuzhang closed pull request #11654: Core, Spark3.5: Fix tests failure due to timeout URL: https://github.com/apache/iceberg/pull/11654 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Core, Spark3.5: Fix tests failure due to timeout [iceberg]

2024-12-11 Thread via GitHub
manuzhang commented on PR #11654: URL: https://github.com/apache/iceberg/pull/11654#issuecomment-2535495990 @nastra Please take another look, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Core, Spark3.5: Fix tests failure due to timeout [iceberg]

2024-12-10 Thread via GitHub
manuzhang commented on code in PR #11654: URL: https://github.com/apache/iceberg/pull/11654#discussion_r185553 ## core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCommits.java: ## @@ -421,7 +423,13 @@ public void testConcurrentFastAppends(@TempDir File dir) throws Exc

Re: [PR] Core, Spark3.5: Fix tests failure due to timeout [iceberg]

2024-11-27 Thread via GitHub
nastra commented on code in PR #11654: URL: https://github.com/apache/iceberg/pull/11654#discussion_r1860894153 ## core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCommits.java: ## @@ -421,7 +422,7 @@ public void testConcurrentFastAppends(@TempDir File dir) throws Excepti

Re: [PR] Core, Spark3.5: Fix tests failure due to timeout [iceberg]

2024-11-27 Thread via GitHub
manuzhang closed pull request #11654: Core, Spark3.5: Fix tests failure due to timeout URL: https://github.com/apache/iceberg/pull/11654 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Core, Spark3.5: Fix tests failure due to timeout [iceberg]

2024-11-26 Thread via GitHub
manuzhang commented on code in PR #11654: URL: https://github.com/apache/iceberg/pull/11654#discussion_r1859767751 ## core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCommits.java: ## @@ -446,7 +446,7 @@ public void testConcurrentFastAppends(@TempDir File dir) throws Exce

Re: [PR] Core, Spark3.5: Fix tests failure due to timeout [iceberg]

2024-11-26 Thread via GitHub
nastra commented on code in PR #11654: URL: https://github.com/apache/iceberg/pull/11654#discussion_r1858896301 ## core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCommits.java: ## @@ -446,7 +446,7 @@ public void testConcurrentFastAppends(@TempDir File dir) throws Excepti

Re: [PR] Core, Spark3.5: Fix tests failure due to timeout [iceberg]

2024-11-26 Thread via GitHub
manuzhang closed pull request #11654: Core, Spark3.5: Fix tests failure due to timeout URL: https://github.com/apache/iceberg/pull/11654 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific