nastra commented on code in PR #11654:
URL: https://github.com/apache/iceberg/pull/11654#discussion_r1858896301
##########
core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCommits.java:
##########
@@ -446,7 +446,7 @@ public void testConcurrentFastAppends(@TempDir File dir)
throws Exception {
final int currentFilesCount = numCommittedFiles;
Awaitility.await()
.pollInterval(Duration.ofMillis(10))
- .atMost(Duration.ofSeconds(10))
+ .atMost(Duration.ofSeconds(20))
Review Comment:
I'm not sure increasing the timeout is the right thing to do here. Isn't
this an issue due to exponential retries during concurrent commits? I'd
probably rather define/decrease
https://github.com/apache/iceberg/blob/ea5da1789f3eb80fc3196bcdd787a95ac0c493ba/core/src/main/java/org/apache/iceberg/TableProperties.java#L89-L92
for this test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
