aokolnychyi commented on PR #11476:
URL: https://github.com/apache/iceberg/pull/11476#issuecomment-2460726490
Thanks for reviewing, @nastra @danielcweeks @jbonofre @rdblue!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
aokolnychyi merged PR #11476:
URL: https://github.com/apache/iceberg/pull/11476
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@icebe
aokolnychyi commented on code in PR #11476:
URL: https://github.com/apache/iceberg/pull/11476#discussion_r1831651242
##
data/src/test/java/org/apache/iceberg/io/TestDVWriters.java:
##
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mor
aokolnychyi commented on code in PR #11476:
URL: https://github.com/apache/iceberg/pull/11476#discussion_r1830585211
##
data/src/test/java/org/apache/iceberg/io/TestDVWriters.java:
##
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mor
aokolnychyi commented on code in PR #11476:
URL: https://github.com/apache/iceberg/pull/11476#discussion_r1830494978
##
core/src/main/java/org/apache/iceberg/util/StructLikeUtil.java:
##
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or m
aokolnychyi commented on code in PR #11476:
URL: https://github.com/apache/iceberg/pull/11476#discussion_r1830590005
##
core/src/main/java/org/apache/iceberg/deletes/DVFileWriter.java:
##
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
aokolnychyi commented on code in PR #11476:
URL: https://github.com/apache/iceberg/pull/11476#discussion_r1830583616
##
core/src/main/java/org/apache/iceberg/deletes/BaseDVFileWriter.java:
##
@@ -0,0 +1,194 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
nastra commented on code in PR #11476:
URL: https://github.com/apache/iceberg/pull/11476#discussion_r1830504286
##
data/src/test/java/org/apache/iceberg/io/TestDVWriters.java:
##
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more con
nastra commented on code in PR #11476:
URL: https://github.com/apache/iceberg/pull/11476#discussion_r1830500893
##
core/src/main/java/org/apache/iceberg/deletes/BaseDVFileWriter.java:
##
@@ -0,0 +1,194 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
aokolnychyi commented on code in PR #11476:
URL: https://github.com/apache/iceberg/pull/11476#discussion_r1830494978
##
core/src/main/java/org/apache/iceberg/util/StructLikeUtil.java:
##
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or m
aokolnychyi commented on code in PR #11476:
URL: https://github.com/apache/iceberg/pull/11476#discussion_r1830494500
##
core/src/main/java/org/apache/iceberg/io/StructCopy.java:
##
@@ -21,8 +21,8 @@
import org.apache.iceberg.StructLike;
/** Copy the StructLike's values into
jbonofre commented on code in PR #11476:
URL: https://github.com/apache/iceberg/pull/11476#discussion_r1830473765
##
core/src/main/java/org/apache/iceberg/deletes/DVFileWriter.java:
##
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mor
jbonofre commented on code in PR #11476:
URL: https://github.com/apache/iceberg/pull/11476#discussion_r1830471333
##
core/src/main/java/org/apache/iceberg/io/StructCopy.java:
##
@@ -21,8 +21,8 @@
import org.apache.iceberg.StructLike;
/** Copy the StructLike's values into a n
rdblue commented on code in PR #11476:
URL: https://github.com/apache/iceberg/pull/11476#discussion_r1830146472
##
core/src/main/java/org/apache/iceberg/io/StructCopy.java:
##
@@ -21,8 +21,8 @@
import org.apache.iceberg.StructLike;
/** Copy the StructLike's values into a new
rdblue commented on code in PR #11476:
URL: https://github.com/apache/iceberg/pull/11476#discussion_r1830120314
##
core/src/main/java/org/apache/iceberg/deletes/BaseDVFileWriter.java:
##
@@ -0,0 +1,194 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
aokolnychyi commented on code in PR #11476:
URL: https://github.com/apache/iceberg/pull/11476#discussion_r1830015007
##
core/src/main/java/org/apache/iceberg/deletes/DVFileWriter.java:
##
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
aokolnychyi commented on code in PR #11476:
URL: https://github.com/apache/iceberg/pull/11476#discussion_r1830014006
##
core/src/main/java/org/apache/iceberg/io/StructCopy.java:
##
@@ -21,8 +21,8 @@
import org.apache.iceberg.StructLike;
/** Copy the StructLike's values into
danielcweeks commented on code in PR #11476:
URL: https://github.com/apache/iceberg/pull/11476#discussion_r1829993504
##
core/src/main/java/org/apache/iceberg/io/StructCopy.java:
##
@@ -21,8 +21,8 @@
import org.apache.iceberg.StructLike;
/** Copy the StructLike's values into
danielcweeks commented on code in PR #11476:
URL: https://github.com/apache/iceberg/pull/11476#discussion_r1829991655
##
core/src/main/java/org/apache/iceberg/deletes/DVFileWriter.java:
##
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
aokolnychyi commented on code in PR #11476:
URL: https://github.com/apache/iceberg/pull/11476#discussion_r1829922422
##
core/src/main/java/org/apache/iceberg/deletes/BaseDVFileWriter.java:
##
@@ -0,0 +1,194 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
danielcweeks commented on code in PR #11476:
URL: https://github.com/apache/iceberg/pull/11476#discussion_r1829761144
##
core/src/main/java/org/apache/iceberg/deletes/BaseDVFileWriter.java:
##
@@ -0,0 +1,194 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
jbonofre commented on code in PR #11476:
URL: https://github.com/apache/iceberg/pull/11476#discussion_r1829703181
##
core/src/main/java/org/apache/iceberg/io/StructCopy.java:
##
@@ -21,8 +21,8 @@
import org.apache.iceberg.StructLike;
/** Copy the StructLike's values into a n
aokolnychyi commented on code in PR #11476:
URL: https://github.com/apache/iceberg/pull/11476#discussion_r1829672080
##
core/src/main/java/org/apache/iceberg/deletes/BaseDVFileWriter.java:
##
@@ -0,0 +1,194 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
aokolnychyi commented on code in PR #11476:
URL: https://github.com/apache/iceberg/pull/11476#discussion_r1829669340
##
data/src/test/java/org/apache/iceberg/io/TestDVWriters.java:
##
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mor
aokolnychyi commented on code in PR #11476:
URL: https://github.com/apache/iceberg/pull/11476#discussion_r1829659538
##
core/src/main/java/org/apache/iceberg/io/StructCopy.java:
##
@@ -21,8 +21,8 @@
import org.apache.iceberg.StructLike;
/** Copy the StructLike's values into
aokolnychyi commented on code in PR #11476:
URL: https://github.com/apache/iceberg/pull/11476#discussion_r1829658091
##
core/src/main/java/org/apache/iceberg/deletes/BaseDVFileWriter.java:
##
@@ -0,0 +1,194 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
26 matches
Mail list logo