Re: [PR] Core, Puffin: Add DV file writer [iceberg]

2024-11-06 Thread via GitHub
aokolnychyi commented on PR #11476: URL: https://github.com/apache/iceberg/pull/11476#issuecomment-2460726490 Thanks for reviewing, @nastra @danielcweeks @jbonofre @rdblue! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] Core, Puffin: Add DV file writer [iceberg]

2024-11-06 Thread via GitHub
aokolnychyi merged PR #11476: URL: https://github.com/apache/iceberg/pull/11476 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@icebe

Re: [PR] Core, Puffin: Add DV file writer [iceberg]

2024-11-06 Thread via GitHub
aokolnychyi commented on code in PR #11476: URL: https://github.com/apache/iceberg/pull/11476#discussion_r1831651242 ## data/src/test/java/org/apache/iceberg/io/TestDVWriters.java: ## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

Re: [PR] Core, Puffin: Add DV file writer [iceberg]

2024-11-06 Thread via GitHub
aokolnychyi commented on code in PR #11476: URL: https://github.com/apache/iceberg/pull/11476#discussion_r1830585211 ## data/src/test/java/org/apache/iceberg/io/TestDVWriters.java: ## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

Re: [PR] Core, Puffin: Add DV file writer [iceberg]

2024-11-06 Thread via GitHub
aokolnychyi commented on code in PR #11476: URL: https://github.com/apache/iceberg/pull/11476#discussion_r1830494978 ## core/src/main/java/org/apache/iceberg/util/StructLikeUtil.java: ## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] Core, Puffin: Add DV file writer [iceberg]

2024-11-06 Thread via GitHub
aokolnychyi commented on code in PR #11476: URL: https://github.com/apache/iceberg/pull/11476#discussion_r1830590005 ## core/src/main/java/org/apache/iceberg/deletes/DVFileWriter.java: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Core, Puffin: Add DV file writer [iceberg]

2024-11-06 Thread via GitHub
aokolnychyi commented on code in PR #11476: URL: https://github.com/apache/iceberg/pull/11476#discussion_r1830583616 ## core/src/main/java/org/apache/iceberg/deletes/BaseDVFileWriter.java: ## @@ -0,0 +1,194 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] Core, Puffin: Add DV file writer [iceberg]

2024-11-05 Thread via GitHub
nastra commented on code in PR #11476: URL: https://github.com/apache/iceberg/pull/11476#discussion_r1830504286 ## data/src/test/java/org/apache/iceberg/io/TestDVWriters.java: ## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more con

Re: [PR] Core, Puffin: Add DV file writer [iceberg]

2024-11-05 Thread via GitHub
nastra commented on code in PR #11476: URL: https://github.com/apache/iceberg/pull/11476#discussion_r1830500893 ## core/src/main/java/org/apache/iceberg/deletes/BaseDVFileWriter.java: ## @@ -0,0 +1,194 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Core, Puffin: Add DV file writer [iceberg]

2024-11-05 Thread via GitHub
aokolnychyi commented on code in PR #11476: URL: https://github.com/apache/iceberg/pull/11476#discussion_r1830494978 ## core/src/main/java/org/apache/iceberg/util/StructLikeUtil.java: ## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] Core, Puffin: Add DV file writer [iceberg]

2024-11-05 Thread via GitHub
aokolnychyi commented on code in PR #11476: URL: https://github.com/apache/iceberg/pull/11476#discussion_r1830494500 ## core/src/main/java/org/apache/iceberg/io/StructCopy.java: ## @@ -21,8 +21,8 @@ import org.apache.iceberg.StructLike; /** Copy the StructLike's values into

Re: [PR] Core, Puffin: Add DV file writer [iceberg]

2024-11-05 Thread via GitHub
jbonofre commented on code in PR #11476: URL: https://github.com/apache/iceberg/pull/11476#discussion_r1830473765 ## core/src/main/java/org/apache/iceberg/deletes/DVFileWriter.java: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

Re: [PR] Core, Puffin: Add DV file writer [iceberg]

2024-11-05 Thread via GitHub
jbonofre commented on code in PR #11476: URL: https://github.com/apache/iceberg/pull/11476#discussion_r1830471333 ## core/src/main/java/org/apache/iceberg/io/StructCopy.java: ## @@ -21,8 +21,8 @@ import org.apache.iceberg.StructLike; /** Copy the StructLike's values into a n

Re: [PR] Core, Puffin: Add DV file writer [iceberg]

2024-11-05 Thread via GitHub
rdblue commented on code in PR #11476: URL: https://github.com/apache/iceberg/pull/11476#discussion_r1830146472 ## core/src/main/java/org/apache/iceberg/io/StructCopy.java: ## @@ -21,8 +21,8 @@ import org.apache.iceberg.StructLike; /** Copy the StructLike's values into a new

Re: [PR] Core, Puffin: Add DV file writer [iceberg]

2024-11-05 Thread via GitHub
rdblue commented on code in PR #11476: URL: https://github.com/apache/iceberg/pull/11476#discussion_r1830120314 ## core/src/main/java/org/apache/iceberg/deletes/BaseDVFileWriter.java: ## @@ -0,0 +1,194 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Core, Puffin: Add DV file writer [iceberg]

2024-11-05 Thread via GitHub
aokolnychyi commented on code in PR #11476: URL: https://github.com/apache/iceberg/pull/11476#discussion_r1830015007 ## core/src/main/java/org/apache/iceberg/deletes/DVFileWriter.java: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Core, Puffin: Add DV file writer [iceberg]

2024-11-05 Thread via GitHub
aokolnychyi commented on code in PR #11476: URL: https://github.com/apache/iceberg/pull/11476#discussion_r1830014006 ## core/src/main/java/org/apache/iceberg/io/StructCopy.java: ## @@ -21,8 +21,8 @@ import org.apache.iceberg.StructLike; /** Copy the StructLike's values into

Re: [PR] Core, Puffin: Add DV file writer [iceberg]

2024-11-05 Thread via GitHub
danielcweeks commented on code in PR #11476: URL: https://github.com/apache/iceberg/pull/11476#discussion_r1829993504 ## core/src/main/java/org/apache/iceberg/io/StructCopy.java: ## @@ -21,8 +21,8 @@ import org.apache.iceberg.StructLike; /** Copy the StructLike's values into

Re: [PR] Core, Puffin: Add DV file writer [iceberg]

2024-11-05 Thread via GitHub
danielcweeks commented on code in PR #11476: URL: https://github.com/apache/iceberg/pull/11476#discussion_r1829991655 ## core/src/main/java/org/apache/iceberg/deletes/DVFileWriter.java: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Core, Puffin: Add DV file writer [iceberg]

2024-11-05 Thread via GitHub
aokolnychyi commented on code in PR #11476: URL: https://github.com/apache/iceberg/pull/11476#discussion_r1829922422 ## core/src/main/java/org/apache/iceberg/deletes/BaseDVFileWriter.java: ## @@ -0,0 +1,194 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] Core, Puffin: Add DV file writer [iceberg]

2024-11-05 Thread via GitHub
danielcweeks commented on code in PR #11476: URL: https://github.com/apache/iceberg/pull/11476#discussion_r1829761144 ## core/src/main/java/org/apache/iceberg/deletes/BaseDVFileWriter.java: ## @@ -0,0 +1,194 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] Core, Puffin: Add DV file writer [iceberg]

2024-11-05 Thread via GitHub
jbonofre commented on code in PR #11476: URL: https://github.com/apache/iceberg/pull/11476#discussion_r1829703181 ## core/src/main/java/org/apache/iceberg/io/StructCopy.java: ## @@ -21,8 +21,8 @@ import org.apache.iceberg.StructLike; /** Copy the StructLike's values into a n

Re: [PR] Core, Puffin: Add DV file writer [iceberg]

2024-11-05 Thread via GitHub
aokolnychyi commented on code in PR #11476: URL: https://github.com/apache/iceberg/pull/11476#discussion_r1829672080 ## core/src/main/java/org/apache/iceberg/deletes/BaseDVFileWriter.java: ## @@ -0,0 +1,194 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] Core, Puffin: Add DV file writer [iceberg]

2024-11-05 Thread via GitHub
aokolnychyi commented on code in PR #11476: URL: https://github.com/apache/iceberg/pull/11476#discussion_r1829669340 ## data/src/test/java/org/apache/iceberg/io/TestDVWriters.java: ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

Re: [PR] Core, Puffin: Add DV file writer [iceberg]

2024-11-05 Thread via GitHub
aokolnychyi commented on code in PR #11476: URL: https://github.com/apache/iceberg/pull/11476#discussion_r1829659538 ## core/src/main/java/org/apache/iceberg/io/StructCopy.java: ## @@ -21,8 +21,8 @@ import org.apache.iceberg.StructLike; /** Copy the StructLike's values into

Re: [PR] Core, Puffin: Add DV file writer [iceberg]

2024-11-05 Thread via GitHub
aokolnychyi commented on code in PR #11476: URL: https://github.com/apache/iceberg/pull/11476#discussion_r1829658091 ## core/src/main/java/org/apache/iceberg/deletes/BaseDVFileWriter.java: ## @@ -0,0 +1,194 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +