rdblue commented on code in PR #11476:
URL: https://github.com/apache/iceberg/pull/11476#discussion_r1830146472


##########
core/src/main/java/org/apache/iceberg/io/StructCopy.java:
##########
@@ -21,8 +21,8 @@
 import org.apache.iceberg.StructLike;
 
 /** Copy the StructLike's values into a new one. It does not handle list or 
map values now. */
-class StructCopy implements StructLike {

Review Comment:
   +1 for `StructLikeUtil` or similar.
   
   @jbonofre, the `io` classes typically refer to `FileIO` and buffer 
management utils in Iceberg. I'm not quite sure why this is currently in the 
`io` package. I think it's probably better to not continue using `io` so that 
it's easier to find later.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to