HonahX merged PR #219:
URL: https://github.com/apache/iceberg-python/pull/219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg
HonahX commented on PR #219:
URL: https://github.com/apache/iceberg-python/pull/219#issuecomment-1899489715
All reviews related to "Apply Name Mapping" are resolved. Let's get this in
and continue our discussion in
https://github.com/apache/iceberg-python/issues/278 😊. Thanks @syun64
--
syun64 commented on PR #219:
URL: https://github.com/apache/iceberg-python/pull/219#issuecomment-1899240128
Need help merging this in as well :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
HonahX commented on PR #219:
URL: https://github.com/apache/iceberg-python/pull/219#issuecomment-1899230673
Thanks for the great work!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
syun64 commented on code in PR #219:
URL: https://github.com/apache/iceberg-python/pull/219#discussion_r1451652305
##
pyiceberg/io/pyarrow.py:
##
@@ -698,77 +708,143 @@ def before_field(self, field: pa.Field) -> None:
def after_field(self, field: pa.Field) -> None:
HonahX commented on code in PR #219:
URL: https://github.com/apache/iceberg-python/pull/219#discussion_r1451632412
##
pyiceberg/io/pyarrow.py:
##
@@ -698,77 +708,143 @@ def before_field(self, field: pa.Field) -> None:
def after_field(self, field: pa.Field) -> None:
syun64 commented on code in PR #219:
URL: https://github.com/apache/iceberg-python/pull/219#discussion_r1451023397
##
pyiceberg/io/pyarrow.py:
##
@@ -698,77 +708,143 @@ def before_field(self, field: pa.Field) -> None:
def after_field(self, field: pa.Field) -> None:
Fokko commented on code in PR #219:
URL: https://github.com/apache/iceberg-python/pull/219#discussion_r1450994558
##
pyiceberg/io/pyarrow.py:
##
@@ -698,77 +708,143 @@ def before_field(self, field: pa.Field) -> None:
def after_field(self, field: pa.Field) -> None:
Fokko commented on code in PR #219:
URL: https://github.com/apache/iceberg-python/pull/219#discussion_r1449403730
##
pyiceberg/io/pyarrow.py:
##
@@ -620,9 +624,18 @@ def _combine_positional_deletes(positional_deletes:
List[pa.ChunkedArray], rows:
return np.setdiff1d(np.ara
syun64 commented on code in PR #219:
URL: https://github.com/apache/iceberg-python/pull/219#discussion_r1450524326
##
pyiceberg/io/pyarrow.py:
##
@@ -698,77 +708,143 @@ def before_field(self, field: pa.Field) -> None:
def after_field(self, field: pa.Field) -> None:
HonahX commented on code in PR #219:
URL: https://github.com/apache/iceberg-python/pull/219#discussion_r1434661513
##
pyiceberg/io/pyarrow.py:
##
@@ -698,77 +708,147 @@ def before_field(self, field: pa.Field) -> None:
def after_field(self, field: pa.Field) -> None:
syun64 commented on PR #219:
URL: https://github.com/apache/iceberg-python/pull/219#issuecomment-1866426126
> Thanks @syun64 for the great work!
Thank you for the detailed review @HonahX ! I've taken most of your
suggestions, and left a response to the one regarding field_type - pleas
syun64 commented on code in PR #219:
URL: https://github.com/apache/iceberg-python/pull/219#discussion_r1434067495
##
pyiceberg/io/pyarrow.py:
##
@@ -698,77 +708,147 @@ def before_field(self, field: pa.Field) -> None:
def after_field(self, field: pa.Field) -> None:
HonahX commented on code in PR #219:
URL: https://github.com/apache/iceberg-python/pull/219#discussion_r1433405001
##
pyiceberg/io/pyarrow.py:
##
@@ -828,7 +933,9 @@ def _task_to_table(
schema_raw = metadata.get(ICEBERG_SCHEMA)
# TODO: if field_ids are not
syun64 commented on PR #219:
URL: https://github.com/apache/iceberg-python/pull/219#issuecomment-1863321308
I've discussed extensively with @fokko regarding how we'd like to handle the
edge cases, and here's the summary of the logic that I've implemented in the
current version:
1. Ha
Fokko commented on PR #219:
URL: https://github.com/apache/iceberg-python/pull/219#issuecomment-1862866272
@syun64 thanks again for working on this. When there are no IDs and there is
no field-mapping. I think we should fall back to assigning IDs, similar that we
do in Java:
https://github
syun64 commented on PR #219:
URL: https://github.com/apache/iceberg-python/pull/219#issuecomment-1862055260
Hi folks, I've rebased the branch from main to reflect the changes in [Add
name-mapping](https://github.com/apache/iceberg-python/pull/212), and added
some negative test cases.
syun64 commented on PR #219:
URL: https://github.com/apache/iceberg-python/pull/219#issuecomment-1860863136
Thank you for the context @rdblue . I will remove the fallback logic from
`pyarrow_to_schema` and ignore setting identifier_field_ids property in
`_ApplyNameMapping`
--
This is an
18 matches
Mail list logo
