Fokko commented on PR #927:
URL: https://github.com/apache/iceberg-python/pull/927#issuecomment-2227455479
Thanks for fixing this @spock-abadai and thanks for the review @kevinjqliu 🙌
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Fokko merged PR #927:
URL: https://github.com/apache/iceberg-python/pull/927
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
Fokko commented on PR #927:
URL: https://github.com/apache/iceberg-python/pull/927#issuecomment-2227217603
@spock-abadai Thanks again for working on this. I think we're almost there.
Can you run `make lint` to fix the formatting issue? Thanks!
--
This is an automated message from the Apac
spock-abadai commented on PR #927:
URL: https://github.com/apache/iceberg-python/pull/927#issuecomment-2227208143
> Thanks for raising this PR @spock-abadai
>
> I think we should update line 40 as well:
>
>
https://github.com/apache/iceberg-python/blob/3f44dfe711e96beda6aa8622c
spock-abadai commented on code in PR #927:
URL: https://github.com/apache/iceberg-python/pull/927#discussion_r1677034401
##
tests/table/test_name_mapping.py:
##
@@ -247,11 +247,6 @@ def test_mapping_lookup_by_name(table_name_mapping_nested:
NameMapping) -> None:
table_
kevinjqliu commented on code in PR #927:
URL: https://github.com/apache/iceberg-python/pull/927#discussion_r1676974835
##
tests/table/test_name_mapping.py:
##
@@ -247,11 +247,6 @@ def test_mapping_lookup_by_name(table_name_mapping_nested:
NameMapping) -> None:
table_na
