kevinjqliu commented on code in PR #927:
URL: https://github.com/apache/iceberg-python/pull/927#discussion_r1676974835


##########
tests/table/test_name_mapping.py:
##########
@@ -247,11 +247,6 @@ def test_mapping_lookup_by_name(table_name_mapping_nested: 
NameMapping) -> None:
         table_name_mapping_nested.find("boom")
 
 
-def test_invalid_mapped_field() -> None:

Review Comment:
   nit: can we add a test to check for `permits an empty list of names in the 
default name mapping`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to