kevinjqliu commented on PR #1920:
URL: https://github.com/apache/iceberg-python/pull/1920#issuecomment-2818994966
Thanks for the contribution @rchowell!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
kevinjqliu commented on code in PR #1920:
URL: https://github.com/apache/iceberg-python/pull/1920#discussion_r2052699626
##
pyiceberg/catalog/glue.py:
##
@@ -303,32 +303,46 @@ def add_glue_catalog_id(params: Dict[str, str], **kwargs:
Any) -> None:
class GlueCatalog(Metasto
kevinjqliu merged PR #1920:
URL: https://github.com/apache/iceberg-python/pull/1920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@i
rchowell commented on code in PR #1920:
URL: https://github.com/apache/iceberg-python/pull/1920#discussion_r2052639531
##
pyiceberg/catalog/glue.py:
##
@@ -303,32 +303,46 @@ def add_glue_catalog_id(params: Dict[str, str], **kwargs:
Any) -> None:
class GlueCatalog(Metastore
kevinjqliu commented on code in PR #1920:
URL: https://github.com/apache/iceberg-python/pull/1920#discussion_r2051549225
##
pyiceberg/catalog/glue.py:
##
@@ -303,32 +303,46 @@ def add_glue_catalog_id(params: Dict[str, str], **kwargs:
Any) -> None:
class GlueCatalog(Metasto
Fokko commented on PR #1920:
URL: https://github.com/apache/iceberg-python/pull/1920#issuecomment-2810688405
Thanks for working on this @rchowell I've left some small comments, but it
looks good in general 👍
--
This is an automated message from the Apache Git Service.
To respond to the m
Fokko commented on code in PR #1920:
URL: https://github.com/apache/iceberg-python/pull/1920#discussion_r2047694347
##
pyiceberg/catalog/glue.py:
##
@@ -303,11 +303,17 @@ def add_glue_catalog_id(params: Dict[str, str], **kwargs:
Any) -> None:
class GlueCatalog(MetastoreCat
Fokko commented on code in PR #1920:
URL: https://github.com/apache/iceberg-python/pull/1920#discussion_r2047692676
##
pyiceberg/catalog/glue.py:
##
@@ -303,11 +303,17 @@ def add_glue_catalog_id(params: Dict[str, str], **kwargs:
Any) -> None:
class GlueCatalog(MetastoreCat
jayceslesar commented on PR #1920:
URL: https://github.com/apache/iceberg-python/pull/1920#issuecomment-2810451425
Nice, I can see myself re-using the client I would instantiate in a custom
resource to run infra changes on my iceberg tables through CDK!
--
This is an automated message fro
