Fokko commented on code in PR #1920: URL: https://github.com/apache/iceberg-python/pull/1920#discussion_r2047694347
########## pyiceberg/catalog/glue.py: ########## @@ -303,11 +303,17 @@ def add_glue_catalog_id(params: Dict[str, str], **kwargs: Any) -> None: class GlueCatalog(MetastoreCatalog): - def __init__(self, name: str, **properties: Any): + glue: GlueClient + + def __init__(self, name: str, client: GlueClient | None = None, **properties: Any): Review Comment: Can we add a docstring? Similar to https://github.com/apache/iceberg-python/blob/3c521679d7189e4b8fb35d070442207357d4b41c/pyiceberg/catalog/rest/__init__.py#L254-L261 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
