Re: [PR] Add method and property around sequence-numbers [iceberg-python]

2023-10-11 Thread via GitHub
Fokko commented on code in PR #60: URL: https://github.com/apache/iceberg-python/pull/60#discussion_r1355660181 ## pyiceberg/table/__init__.py: ## @@ -529,6 +529,13 @@ def location(self) -> str: """Return the table's base location.""" return self.metadata.locat

Re: [PR] Add method and property around sequence-numbers [iceberg-python]

2023-10-11 Thread via GitHub
rdblue commented on code in PR #60: URL: https://github.com/apache/iceberg-python/pull/60#discussion_r1355656751 ## pyiceberg/table/__init__.py: ## @@ -529,6 +529,13 @@ def location(self) -> str: """Return the table's base location.""" return self.metadata.loca

Re: [PR] Add method and property around sequence-numbers [iceberg-python]

2023-10-11 Thread via GitHub
Fokko merged PR #60: URL: https://github.com/apache/iceberg-python/pull/60 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] Add method and property around sequence-numbers [iceberg-python]

2023-10-11 Thread via GitHub
Fokko commented on PR #60: URL: https://github.com/apache/iceberg-python/pull/60#issuecomment-1757531574 @amogh-jahagirdar thanks for the review, appreciate it. I'm adding them once we start using them, but if you see anything missing that would be useful on its own, feel free to rais

Re: [PR] Add method and property around sequence-numbers [iceberg-python]

2023-10-11 Thread via GitHub
amogh-jahagirdar commented on PR #60: URL: https://github.com/apache/iceberg-python/pull/60#issuecomment-1757334502 Actually nvm on the new APIs, I was confusing with TableMetadata. I do think having table.uuid() would be useful, that came up recently internally. I'll propose that in the Ja

Re: [PR] Add method and property around sequence-numbers [iceberg-python]

2023-10-11 Thread via GitHub
amogh-jahagirdar commented on PR #60: URL: https://github.com/apache/iceberg-python/pull/60#issuecomment-1757284321 Also seems like a few of these APIs are missing like last updated time, last column id, uuid -- This is an automated message from the Apache Git Service. To respond to the m