rdblue commented on code in PR #60:
URL: https://github.com/apache/iceberg-python/pull/60#discussion_r1355656751
##########
pyiceberg/table/__init__.py:
##########
@@ -529,6 +529,13 @@ def location(self) -> str:
"""Return the table's base location."""
return self.metadata.location
+ @property
+ def last_sequence_number(self) -> int:
+ return self.metadata.last_sequence_number
+
+ def next_sequence_number(self) -> int:
Review Comment:
Minor: In Java, this is on TableMetadata, which is an internal class and not
part of the public API. I don't think anyone would call this externally, but if
they did it may not be accurate because the sequence number could be reassigned
for a new snapshot if the commit needs to be retried. I'd probably make this
`_next_sequence_number()` to avoid that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
