Re: [PR] Add ResidualVisitor to compute residuals [iceberg-python]

mrutunjay-kinagi commented on PR #1388: URL: https://github.com/apache/iceberg-python/pull/1388#issuecomment-2651843972 🚀 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Add ResidualVisitor to compute residuals [iceberg-python]

Fokko merged PR #1388: URL: https://github.com/apache/iceberg-python/pull/1388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

Re: [PR] Add ResidualVisitor to compute residuals [iceberg-python]

Fokko commented on PR #1388: URL: https://github.com/apache/iceberg-python/pull/1388#issuecomment-2650619004 Thanks @tusharchou for working on this 🚀 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Add ResidualVisitor to compute residuals [iceberg-python]

Fokko commented on code in PR #1388: URL: https://github.com/apache/iceberg-python/pull/1388#discussion_r1950707206 ## pyiceberg/table/__init__.py: ## @@ -1466,6 +1475,25 @@ def _build_partition_evaluator(self, spec_id: int) -> Callable[[DataFile], bool] # shared insta

Re: [PR] Add ResidualVisitor to compute residuals [iceberg-python]

Fokko commented on code in PR #1388: URL: https://github.com/apache/iceberg-python/pull/1388#discussion_r1950682935 ## tests/expressions/test_residual_evaluator.py: ## @@ -0,0 +1,251 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

Re: [PR] Add ResidualVisitor to compute residuals [iceberg-python]

Fokko commented on code in PR #1388: URL: https://github.com/apache/iceberg-python/pull/1388#discussion_r1950654390 ## tests/expressions/test_residual_evaluator.py: ## @@ -0,0 +1,251 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

Re: [PR] Add ResidualVisitor to compute residuals [iceberg-python]

Fokko commented on code in PR #1388: URL: https://github.com/apache/iceberg-python/pull/1388#discussion_r1944743154 ## pyiceberg/expressions/visitors.py: ## @@ -1731,3 +1732,230 @@ def _can_contain_nulls(self, field_id: int) -> bool: def _can_contain_nans(self, field_id:

Re: [PR] Add ResidualVisitor to compute residuals [iceberg-python]

Fokko commented on code in PR #1388: URL: https://github.com/apache/iceberg-python/pull/1388#discussion_r1944733940 ## pyiceberg/expressions/visitors.py: ## @@ -1731,3 +1732,230 @@ def _can_contain_nulls(self, field_id: int) -> bool: def _can_contain_nans(self, field_id:

Re: [PR] Add ResidualVisitor to compute residuals [iceberg-python]

Fokko commented on code in PR #1388: URL: https://github.com/apache/iceberg-python/pull/1388#discussion_r1944751408 ## pyiceberg/table/__init__.py: ## @@ -1624,6 +1659,40 @@ def to_ray(self) -> ray.data.dataset.Dataset: return ray.data.from_arrow(self.to_arrow()) +

Re: [PR] Add ResidualVisitor to compute residuals [iceberg-python]

Fokko commented on code in PR #1388: URL: https://github.com/apache/iceberg-python/pull/1388#discussion_r1944746576 ## pyiceberg/expressions/visitors.py: ## @@ -1731,3 +1732,230 @@ def _can_contain_nulls(self, field_id: int) -> bool: def _can_contain_nans(self, field_id:

Re: [PR] Add ResidualVisitor to compute residuals [iceberg-python]

Fokko commented on code in PR #1388: URL: https://github.com/apache/iceberg-python/pull/1388#discussion_r1944744615 ## pyiceberg/expressions/visitors.py: ## @@ -1731,3 +1732,230 @@ def _can_contain_nulls(self, field_id: int) -> bool: def _can_contain_nans(self, field_id:

Re: [PR] Add ResidualVisitor to compute residuals [iceberg-python]

Fokko commented on code in PR #1388: URL: https://github.com/apache/iceberg-python/pull/1388#discussion_r1944741812 ## pyiceberg/expressions/visitors.py: ## @@ -1731,3 +1732,230 @@ def _can_contain_nulls(self, field_id: int) -> bool: def _can_contain_nans(self, field_id:

Re: [PR] Add ResidualVisitor to compute residuals [iceberg-python]

Fokko commented on code in PR #1388: URL: https://github.com/apache/iceberg-python/pull/1388#discussion_r1944742544 ## pyiceberg/expressions/visitors.py: ## @@ -1731,3 +1732,230 @@ def _can_contain_nulls(self, field_id: int) -> bool: def _can_contain_nans(self, field_id:

Re: [PR] Add ResidualVisitor to compute residuals [iceberg-python]

Fokko commented on code in PR #1388: URL: https://github.com/apache/iceberg-python/pull/1388#discussion_r1944740942 ## pyiceberg/expressions/visitors.py: ## @@ -1731,3 +1732,230 @@ def _can_contain_nulls(self, field_id: int) -> bool: def _can_contain_nans(self, field_id:

Re: [PR] Add ResidualVisitor to compute residuals [iceberg-python]

Fokko commented on code in PR #1388: URL: https://github.com/apache/iceberg-python/pull/1388#discussion_r1944733940 ## pyiceberg/expressions/visitors.py: ## @@ -1731,3 +1732,230 @@ def _can_contain_nulls(self, field_id: int) -> bool: def _can_contain_nans(self, field_id:

Re: [PR] Add ResidualVisitor to compute residuals [iceberg-python]

Fokko commented on code in PR #1388: URL: https://github.com/apache/iceberg-python/pull/1388#discussion_r1944716694 ## pyiceberg/expressions/visitors.py: ## @@ -1731,3 +1732,230 @@ def _can_contain_nulls(self, field_id: int) -> bool: def _can_contain_nans(self, field_id:

Re: [PR] Add ResidualVisitor to compute residuals [iceberg-python]

Fokko commented on code in PR #1388: URL: https://github.com/apache/iceberg-python/pull/1388#discussion_r1944716167 ## pyiceberg/expressions/visitors.py: ## @@ -1731,3 +1732,230 @@ def _can_contain_nulls(self, field_id: int) -> bool: def _can_contain_nans(self, field_id:

Re: [PR] Add ResidualVisitor to compute residuals [iceberg-python]

Fokko commented on code in PR #1388: URL: https://github.com/apache/iceberg-python/pull/1388#discussion_r1937048705 ## pyiceberg/expressions/visitors.py: ## @@ -1731,3 +1731,214 @@ def _can_contain_nulls(self, field_id: int) -> bool: def _can_contain_nans(self, field_id:

Re: [PR] Add ResidualVisitor to compute residuals [iceberg-python]

tusharchou commented on code in PR #1388: URL: https://github.com/apache/iceberg-python/pull/1388#discussion_r1936663741 ## pyiceberg/expressions/visitors.py: ## @@ -1731,3 +1731,214 @@ def _can_contain_nulls(self, field_id: int) -> bool: def _can_contain_nans(self, field

Re: [PR] Add ResidualVisitor to compute residuals [iceberg-python]

tusharchou commented on code in PR #1388: URL: https://github.com/apache/iceberg-python/pull/1388#discussion_r1936663741 ## pyiceberg/expressions/visitors.py: ## @@ -1731,3 +1731,214 @@ def _can_contain_nulls(self, field_id: int) -> bool: def _can_contain_nans(self, field

Re: [PR] Add ResidualVisitor to compute residuals [iceberg-python]

Fokko commented on code in PR #1388: URL: https://github.com/apache/iceberg-python/pull/1388#discussion_r1922535895 ## pyiceberg/table/__init__.py: ## @@ -1596,6 +1630,43 @@ def to_ray(self) -> ray.data.dataset.Dataset: return ray.data.from_arrow(self.to_arrow()) +

Re: [PR] Add ResidualVisitor to compute residuals [iceberg-python]

tusharchou commented on code in PR #1388: URL: https://github.com/apache/iceberg-python/pull/1388#discussion_r1920238317 ## pyiceberg/expressions/visitors.py: ## @@ -1731,3 +1731,214 @@ def _can_contain_nulls(self, field_id: int) -> bool: def _can_contain_nans(self, field

Re: [PR] Add ResidualVisitor to compute residuals [iceberg-python]

tusharchou commented on code in PR #1388: URL: https://github.com/apache/iceberg-python/pull/1388#discussion_r1920210749 ## pyiceberg/table/__init__.py: ## @@ -1596,6 +1630,43 @@ def to_ray(self) -> ray.data.dataset.Dataset: return ray.data.from_arrow(self.to_arrow())

Re: [PR] Add ResidualVisitor to compute residuals [iceberg-python]

tusharchou commented on code in PR #1388: URL: https://github.com/apache/iceberg-python/pull/1388#discussion_r1920208710 ## pyiceberg/table/__init__.py: ## @@ -1596,6 +1630,43 @@ def to_ray(self) -> ray.data.dataset.Dataset: return ray.data.from_arrow(self.to_arrow())

Re: [PR] Add ResidualVisitor to compute residuals [iceberg-python]

Fokko commented on code in PR #1388: URL: https://github.com/apache/iceberg-python/pull/1388#discussion_r1915102464 ## pyiceberg/table/__init__.py: ## @@ -1522,8 +1555,9 @@ def plan_files(self) -> Iterable[FileScanTask]: data_entry, posi

Re: [PR] Add ResidualVisitor to compute residuals [iceberg-python]

tusharchou commented on code in PR #1388: URL: https://github.com/apache/iceberg-python/pull/1388#discussion_r1915063325 ## pyiceberg/table/__init__.py: ## @@ -1522,8 +1555,9 @@ def plan_files(self) -> Iterable[FileScanTask]: data_entry,

Re: [PR] Add ResidualVisitor to compute residuals [iceberg-python]

Fokko commented on code in PR #1388: URL: https://github.com/apache/iceberg-python/pull/1388#discussion_r1913339866 ## pyiceberg/expressions/visitors.py: ## @@ -1731,3 +1731,214 @@ def _can_contain_nulls(self, field_id: int) -> bool: def _can_contain_nans(self, field_id: