Re: [PR] Add EnumConfParser to SparkConfParser [iceberg]

2024-05-13 Thread via GitHub
huaxingao commented on PR #10311: URL: https://github.com/apache/iceberg/pull/10311#issuecomment-2108854132 Thanks @aokolnychyi @nastra -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Add EnumConfParser to SparkConfParser [iceberg]

2024-05-13 Thread via GitHub
aokolnychyi merged PR #10311: URL: https://github.com/apache/iceberg/pull/10311 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@icebe

Re: [PR] Add EnumConfParser to SparkConfParser [iceberg]

2024-05-13 Thread via GitHub
aokolnychyi commented on code in PR #10311: URL: https://github.com/apache/iceberg/pull/10311#discussion_r1599002997 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkReadConf.java: ## @@ -302,14 +302,12 @@ public PlanningMode dataPlanningMode() { return LOC

Re: [PR] Add EnumConfParser to SparkConfParser [iceberg]

2024-05-13 Thread via GitHub
aokolnychyi commented on code in PR #10311: URL: https://github.com/apache/iceberg/pull/10311#discussion_r1599002997 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkReadConf.java: ## @@ -302,14 +302,12 @@ public PlanningMode dataPlanningMode() { return LOC

Re: [PR] Add EnumConfParser to SparkConfParser [iceberg]

2024-05-13 Thread via GitHub
aokolnychyi commented on code in PR #10311: URL: https://github.com/apache/iceberg/pull/10311#discussion_r1599001671 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkConfParser.java: ## @@ -70,6 +70,10 @@ public DurationConfParser durationConf() { return new

Re: [PR] Add EnumConfParser to SparkConfParser [iceberg]

2024-05-13 Thread via GitHub
aokolnychyi commented on code in PR #10311: URL: https://github.com/apache/iceberg/pull/10311#discussion_r1598997615 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkConfParser.java: ## @@ -197,6 +201,34 @@ private Duration toDuration(String time) { } }

Re: [PR] Add EnumConfParser to SparkConfParser [iceberg]

2024-05-10 Thread via GitHub
huaxingao commented on PR #10311: URL: https://github.com/apache/iceberg/pull/10311#issuecomment-2105457128 cc @aokolnychyi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.