amogh-jahagirdar merged PR #11420:
URL: https://github.com/apache/iceberg/pull/11420
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
amogh-jahagirdar commented on PR #11420:
URL: https://github.com/apache/iceberg/pull/11420#issuecomment-2533397879
I'll go ahead and merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
hsiang-c commented on code in PR #11420:
URL: https://github.com/apache/iceberg/pull/11420#discussion_r1877559085
##
aws/src/test/java/org/apache/iceberg/aws/kms/TestKmsClientProperties.java:
##
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
amogh-jahagirdar commented on code in PR #11420:
URL: https://github.com/apache/iceberg/pull/11420#discussion_r1877295627
##
aws/src/main/java/org/apache/iceberg/aws/AwsClientProperties.java:
##
@@ -154,6 +156,23 @@ public AwsCredentialsProvider credentialsProvider(
return
amogh-jahagirdar commented on code in PR #11420:
URL: https://github.com/apache/iceberg/pull/11420#discussion_r1877290999
##
aws/src/test/java/org/apache/iceberg/aws/kms/TestKmsClientProperties.java:
##
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
hsiang-c commented on code in PR #11420:
URL: https://github.com/apache/iceberg/pull/11420#discussion_r1865124927
##
aws/src/main/java/org/apache/iceberg/aws/kms/KmsClientProperties.java:
##
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
hsiang-c commented on code in PR #11420:
URL: https://github.com/apache/iceberg/pull/11420#discussion_r1865124927
##
aws/src/main/java/org/apache/iceberg/aws/kms/KmsClientProperties.java:
##
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
hsiang-c commented on code in PR #11420:
URL: https://github.com/apache/iceberg/pull/11420#discussion_r1865124927
##
aws/src/main/java/org/apache/iceberg/aws/kms/KmsClientProperties.java:
##
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
amogh-jahagirdar commented on code in PR #11420:
URL: https://github.com/apache/iceberg/pull/11420#discussion_r1839219803
##
aws/src/main/java/org/apache/iceberg/aws/kms/KmsClientProperties.java:
##
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
hsiang-c commented on PR #11420:
URL: https://github.com/apache/iceberg/pull/11420#issuecomment-2463714791
Thanks for your feedback @danielcweeks Please take a look again.
If you still have time, I have another PR for you
https://github.com/apache/iceberg/pull/11321
--
This is an a
danielcweeks commented on PR #11420:
URL: https://github.com/apache/iceberg/pull/11420#issuecomment-2462804351
> Is having too many options a concern to you? I'd like to learn more about
your thoughts.
I feel like the proliferation of options is not a good thing unless there's
real v
hsiang-c commented on PR #11420:
URL: https://github.com/apache/iceberg/pull/11420#issuecomment-2461269631
@danielcweeks Thank you for your review.
> Is this really necessary to make configurable?
I am also working on an enhancement to Iceberg S3 doc:
https://github.com/apache/
danielcweeks commented on PR #11420:
URL: https://github.com/apache/iceberg/pull/11420#issuecomment-2458392694
Is this really necessary to make configurable? Why shouldn't we just set
`ADAPTIVE_V2` as the default when constructing the client? This is only for
retry behavior, I'm not sure
hsiang-c commented on code in PR #11420:
URL: https://github.com/apache/iceberg/pull/11420#discussion_r1821695163
##
aws/src/main/java/org/apache/iceberg/aws/kms/KmsClientProperties.java:
##
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
jbonofre commented on code in PR #11420:
URL: https://github.com/apache/iceberg/pull/11420#discussion_r1820371235
##
aws/src/main/java/org/apache/iceberg/aws/kms/KmsClientProperties.java:
##
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
hsiang-c commented on PR #11420:
URL: https://github.com/apache/iceberg/pull/11420#issuecomment-2443571978
@nastra @jackye1995 please review it when you have time, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
16 matches
Mail list logo
