hsiang-c commented on PR #11420: URL: https://github.com/apache/iceberg/pull/11420#issuecomment-2461269631
@danielcweeks Thank you for your review. > Is this really necessary to make configurable? I am also working on an enhancement to Iceberg S3 doc: https://github.com/apache/iceberg/pull/11321, which makes me think users might want to configure AWS service clients with available configurations provided by the client libraries. > This is only for retry behavior, I'm not sure it's worth even making it an option. Got it, I have no problem with setting `ADAPTIVE_V2` as the default, though the [default mode](https://github.com/aws/aws-sdk-java-v2/blob/2.29.7/core/sdk-core/src/main/java/software/amazon/awssdk/core/retry/RetryMode.java#L133) is `LEGACY` according to AWS Java V2 SDK. Is having too many options a concern to you? I'd like to learn more about your thoughts. Thanks again for your time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
