ajantha-bhat commented on PR #6887:
URL: https://github.com/apache/iceberg/pull/6887#issuecomment-1855384419
Closing as we concluded to undo deprecation.
Fixed by https://github.com/apache/iceberg/pull/5640
--
This is an automated message from the Apache Git Service.
To respond to t
ajantha-bhat closed pull request #6887: API: Replace special case of deprecated
RuntimeIOException
URL: https://github.com/apache/iceberg/pull/6887
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
ajantha-bhat commented on code in PR #6887:
URL: https://github.com/apache/iceberg/pull/6887#discussion_r142508
##
api/src/main/java/org/apache/iceberg/exceptions/FileHandlingException.java:
##
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
ajantha-bhat commented on code in PR #6887:
URL: https://github.com/apache/iceberg/pull/6887#discussion_r1425552569
##
api/src/main/java/org/apache/iceberg/exceptions/FileHandlingException.java:
##
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
Fokko commented on code in PR #6887:
URL: https://github.com/apache/iceberg/pull/6887#discussion_r1425537371
##
api/src/main/java/org/apache/iceberg/exceptions/FileHandlingException.java:
##
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
ajantha-bhat commented on PR #6887:
URL: https://github.com/apache/iceberg/pull/6887#issuecomment-1849920644
PR is ready @danielcweeks, @nastra, @Fokko
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
ajantha-bhat commented on code in PR #6887:
URL: https://github.com/apache/iceberg/pull/6887#discussion_r1422303733
##
core/src/main/java/org/apache/iceberg/avro/AvroFileAppender.java:
##
@@ -78,14 +78,13 @@ public Metrics metrics() {
@Override
public long length() {
-
nastra commented on code in PR #6887:
URL: https://github.com/apache/iceberg/pull/6887#discussion_r1419046382
##
core/src/main/java/org/apache/iceberg/avro/AvroFileAppender.java:
##
@@ -78,14 +78,13 @@ public Metrics metrics() {
@Override
public long length() {
-if (
ajantha-bhat commented on PR #6887:
URL: https://github.com/apache/iceberg/pull/6887#issuecomment-1845411543
@nastra: Thanks for the review. I have replied to comments.
I think no new code modifications needed. Please check again. Thanks.
--
This is an automated message from the
ajantha-bhat commented on code in PR #6887:
URL: https://github.com/apache/iceberg/pull/6887#discussion_r1419010809
##
core/src/main/java/org/apache/iceberg/avro/AvroFileAppender.java:
##
@@ -78,14 +78,13 @@ public Metrics metrics() {
@Override
public long length() {
-
ajantha-bhat commented on code in PR #6887:
URL: https://github.com/apache/iceberg/pull/6887#discussion_r1419002428
##
core/src/main/java/org/apache/iceberg/avro/AvroFileAppender.java:
##
@@ -78,14 +78,13 @@ public Metrics metrics() {
@Override
public long length() {
-
ajantha-bhat commented on code in PR #6887:
URL: https://github.com/apache/iceberg/pull/6887#discussion_r1418998188
##
core/src/main/java/org/apache/iceberg/avro/AvroFileAppender.java:
##
@@ -78,14 +78,13 @@ public Metrics metrics() {
@Override
public long length() {
-
ajantha-bhat commented on code in PR #6887:
URL: https://github.com/apache/iceberg/pull/6887#discussion_r1418998188
##
core/src/main/java/org/apache/iceberg/avro/AvroFileAppender.java:
##
@@ -78,14 +78,13 @@ public Metrics metrics() {
@Override
public long length() {
-
ajantha-bhat commented on code in PR #6887:
URL: https://github.com/apache/iceberg/pull/6887#discussion_r1418996270
##
core/src/main/java/org/apache/iceberg/avro/AvroFileAppender.java:
##
@@ -78,14 +78,13 @@ public Metrics metrics() {
@Override
public long length() {
-
14 matches
Mail list logo
