ajantha-bhat commented on code in PR #6887:
URL: https://github.com/apache/iceberg/pull/6887#discussion_r1418996270
##########
core/src/main/java/org/apache/iceberg/avro/AvroFileAppender.java:
##########
@@ -78,14 +78,13 @@ public Metrics metrics() {
@Override
public long length() {
- if (stream != null) {
- try {
- return stream.getPos();
- } catch (IOException e) {
- throw new RuntimeIOException(e, "Failed to get stream length");
- }
+ Preconditions.checkNotNull(stream, "Failed to get stream length: no open
stream");
Review Comment:
Yes, I changed this to `IllegalStateException` based on Dan's comment last
time.
https://github.com/apache/iceberg/pull/6887#discussion_r1114846404
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
