Re: [PR] [DRAFT] Remove unused code for streaming position deletes [iceberg]

2024-09-25 Thread via GitHub
wypoon commented on PR #11177: URL: https://github.com/apache/iceberg/pull/11177#issuecomment-2374259751 Tests passed. Closing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] [DRAFT] Remove unused code for streaming position deletes [iceberg]

2024-09-25 Thread via GitHub
wypoon closed pull request #11177: [DRAFT] Remove unused code for streaming position deletes URL: https://github.com/apache/iceberg/pull/11177 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] [DRAFT] Remove unused code for streaming position deletes [iceberg]

2024-09-25 Thread via GitHub
nastra commented on code in PR #11177: URL: https://github.com/apache/iceberg/pull/11177#discussion_r1774870225 ## core/src/main/java/org/apache/iceberg/deletes/Deletes.java: ## @@ -192,27 +185,43 @@ public static PositionDeleteIndex toPositionIndex(CloseableIterable posDel