Re: [I] discussion: Simplify `PrimitiveLiteral` type. [iceberg-rust]

2024-07-30 Thread via GitHub
liurenjie1024 commented on issue #501: URL: https://github.com/apache/iceberg-rust/issues/501#issuecomment-2258524166 > > This would make a lot of sense. I was also never keen on the names. Maybe we could rename Datum to `LogicalValue` and have `PhysicalValue` for primitive, similar to Parq

Re: [I] discussion: Simplify `PrimitiveLiteral` type. [iceberg-rust]

2024-07-29 Thread via GitHub
ZENOTME commented on issue #501: URL: https://github.com/apache/iceberg-rust/issues/501#issuecomment-2256319932 I create an init PR #502 for this. I hope it can be a starting point to discuss what's going on if we simplify PrimitiveLiteral. So feel free for any suggestions. -- This is an

Re: [I] discussion: Simplify `PrimitiveLiteral` type. [iceberg-rust]

2024-07-29 Thread via GitHub
sdd commented on issue #501: URL: https://github.com/apache/iceberg-rust/issues/501#issuecomment-2256252671 Actually if we did that it would diverge from the Iceberg spec -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [I] discussion: Simplify `PrimitiveLiteral` type. [iceberg-rust]

2024-07-29 Thread via GitHub
sdd commented on issue #501: URL: https://github.com/apache/iceberg-rust/issues/501#issuecomment-2256250188 This would make a lot of sense. I was also never keen on the names. Maybe we could rename Datum to `LogicalValue` and have `PhysicalValue` for primitive, similar to Parquet? -- Th

Re: [I] discussion: Simplify `PrimitiveLiteral` type. [iceberg-rust]

2024-07-29 Thread via GitHub
ZENOTME commented on issue #501: URL: https://github.com/apache/iceberg-rust/issues/501#issuecomment-2256141727 Also +1 for this and I'm glad to send the PR to do this later if we decide. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [I] discussion: Simplify `PrimitiveLiteral` type. [iceberg-rust]

2024-07-29 Thread via GitHub
Xuanwo commented on issue #501: URL: https://github.com/apache/iceberg-rust/issues/501#issuecomment-2256129508 Thanks for this. I support this change, -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go