liurenjie1024 commented on issue #501: URL: https://github.com/apache/iceberg-rust/issues/501#issuecomment-2258524166
> > This would make a lot of sense. I was also never keen on the names. Maybe we could rename Datum to `LogicalValue` and have `PhysicalValue` for primitive, similar to Parquet? > > I prefer to reserve `Primitive` in name to indicate the primitive value, e.g `LogicalPrimitive` `PhysicalPrimitive` +1 for this. Also we may don't need to actually rename it, just adding an alias would be enough. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
