Re: [I] TableCommit builder's build method should be `pub` [iceberg-rust]

2024-01-15 Thread via GitHub
zeodtr commented on issue #164: URL: https://github.com/apache/iceberg-rust/issues/164#issuecomment-1892985986 @liurenjie1024 Thank you for your quick answer. I'm currently implementing my own `Catalog` to handle my own Iceberg-compatible storage. If adding a snapshot cannot be done

Re: [I] TableCommit builder's build method should be `pub` [iceberg-rust]

2024-01-15 Thread via GitHub
liurenjie1024 commented on issue #164: URL: https://github.com/apache/iceberg-rust/issues/164#issuecomment-1892984071 > @liurenjie1024 Sorry, but there is another question. > > I want to add a `Snapshot` to a `Table` but `Transaction` does not provide a `fn` to do it (`append_updates`

Re: [I] TableCommit builder's build method should be `pub` [iceberg-rust]

2024-01-15 Thread via GitHub
zeodtr commented on issue #164: URL: https://github.com/apache/iceberg-rust/issues/164#issuecomment-1892983347 @liurenjie1024 Sorry, but there is another question. I want to add a `Snapshot` to a `Table` but `Transaction` does not provide a `fn` to do it (`append_updates` is private)

Re: [I] TableCommit builder's build method should be `pub` [iceberg-rust]

2024-01-15 Thread via GitHub
liurenjie1024 closed issue #164: TableCommit builder's build method should be `pub` URL: https://github.com/apache/iceberg-rust/issues/164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [I] TableCommit builder's build method should be `pub` [iceberg-rust]

2024-01-15 Thread via GitHub
zeodtr commented on issue #164: URL: https://github.com/apache/iceberg-rust/issues/164#issuecomment-1892976037 Hi, @liurenjie1024, I see. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] TableCommit builder's build method should be `pub` [iceberg-rust]

2024-01-15 Thread via GitHub
liurenjie1024 commented on issue #164: URL: https://github.com/apache/iceberg-rust/issues/164#issuecomment-1892953624 > Hi, > > Since `Catalog` trait is `pub`, any `struct` used in the `fn`s in the trait should be publically buildable. But `TableCommit`'s builder's builder method's s