liurenjie1024 commented on issue #164: URL: https://github.com/apache/iceberg-rust/issues/164#issuecomment-1892953624
> Hi, > > Since `Catalog` trait is `pub`, any `struct` used in the `fn`s in the trait should be publically buildable. But `TableCommit`'s builder's builder method's scope is explicitly set to `pub(crate)`. So, the code out of the crate cannot call the `update_table()` `fn` since `TableCommit` cannot be built. Is there any reason to limit the scope? Or is there any other way to build it? If not, `TableCommit` builder's build method should be `pub`. > > Thanks. Hi, @zeodtr Thanks for your interest! We make `TableCommitBuilder` private to crate on purpose, since users are not supposed to build `TableCommit` directly. They should use [transaction api](https://github.com/apache/iceberg-rust/blob/a6d98c332385f5e89e8cb643df7ea15c5ec820e7/crates/iceberg/src/transaction.rs#L30) to modify table. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
