Xuanwo merged PR #742:
URL: https://github.com/apache/iceberg-rust/pull/742
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.a
ZENOTME commented on PR #742:
URL: https://github.com/apache/iceberg-rust/pull/742#issuecomment-2523503652
> Hey @Fokko 👋🏻
>
> Thanks a lot for checking up in detail! Can I take up both of the issues
as both are related to this test itself? 😅
>
> Also, slightly tangential, but
ZENOTME commented on code in PR #742:
URL: https://github.com/apache/iceberg-rust/pull/742#discussion_r1873487448
##
crates/integration_tests/tests/append_partition_data_file_test.rs:
##
@@ -0,0 +1,214 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
feniljain commented on PR #742:
URL: https://github.com/apache/iceberg-rust/pull/742#issuecomment-2516279844
Hey @Fokko 👋🏻
Thanks a lot for checking up in detail! Can I take up both of the issues are
both are corresponding to same test?
Also a small idea 💡, do you think we sho
Fokko commented on PR #742:
URL: https://github.com/apache/iceberg-rust/pull/742#issuecomment-2515564242
Did some checks:
First `metadata.json`:
```json
{
"format-version" : 2,
"table-uuid" : "eb83b77f-c2c3-473c-a138-444a3de61213",
"location" :
"s3://icebergda
feniljain opened a new pull request, #742:
URL: https://github.com/apache/iceberg-rust/pull/742
## Issue Resolved
Closes #720
## Description
- Have added test case for base partition data file addition
- Added a test case where different "type" of partition field is s
