feniljain commented on PR #742: URL: https://github.com/apache/iceberg-rust/pull/742#issuecomment-2516279844
Hey @Fokko 👋🏻 Thanks a lot for checking up in detail! Can I take up both of the issues are both are corresponding to same test? Also a small idea 💡, do you think we should use snapshot based testing over these files for end-to-end tests? I have seen the idea being used with great success in projects like rust-analyzer before, crates like https://docs.rs/insta/latest/insta/ can help us with setting it up. This way we wouldn't have to check a lot of fields always and can just compare + evolve snapshots as new features are added easily :) If you think I should create a new issue to discuss this, do lemme know, will do that :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
