Re: [PR] source-ids is not supported on Iceberg v1,2 [iceberg-python]

2025-06-18 Thread via GitHub
rambleraptor commented on code in PR #2114: URL: https://github.com/apache/iceberg-python/pull/2114#discussion_r2155461407 ## pyiceberg/partitioning.py: ## @@ -86,6 +86,7 @@ class PartitionField(IcebergBaseModel): def __init__( self, +format_version: Opti

Re: [PR] source-ids is not supported on Iceberg v1,2 [iceberg-python]

2025-06-18 Thread via GitHub
rambleraptor commented on PR #2114: URL: https://github.com/apache/iceberg-python/pull/2114#issuecomment-2985637012 That makes a lot of sense for v3. But, it looks like `source-ids` is supported on v1/v2, which the spec explicitly disallows. We'd have to carry through the table version to f

Re: [PR] source-ids is not supported on Iceberg v1,2 [iceberg-python]

2025-06-18 Thread via GitHub
Fokko commented on code in PR #2114: URL: https://github.com/apache/iceberg-python/pull/2114#discussion_r2155332678 ## pyiceberg/partitioning.py: ## @@ -86,6 +86,7 @@ class PartitionField(IcebergBaseModel): def __init__( self, +format_version: Optional[in

[PR] source-ids is not supported on Iceberg v1,2 [iceberg-python]

2025-06-17 Thread via GitHub
rambleraptor opened a new pull request, #2114: URL: https://github.com/apache/iceberg-python/pull/2114 Closes #1547 # Rationale for this change The field `source-ids` is being introduced for Iceberg v3. According to the spec, it should not be supported by Iceberg v1 + v