Fokko commented on code in PR #2114:
URL: https://github.com/apache/iceberg-python/pull/2114#discussion_r2155332678
##########
pyiceberg/partitioning.py:
##########
@@ -86,6 +86,7 @@ class PartitionField(IcebergBaseModel):
def __init__(
self,
+ format_version: Optional[int] = None,
Review Comment:
This breaks the current API. When existing users create a PartitionField,
they expect the first argument to be `source-id`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
