Re: [PR] refactor: remove unwraps [iceberg-rust]

2024-02-19 Thread via GitHub
Fokko merged PR #196: URL: https://github.com/apache/iceberg-rust/pull/196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

[PR] refactor: remove unwraps [iceberg-rust]

2024-02-14 Thread via GitHub
odysa opened a new pull request, #196: URL: https://github.com/apache/iceberg-rust/pull/196 Remove `unwrap` and `expect`. It looks like some `expect` are expected. For example ```rust pub fn current_snapshot(&self) -> Option<&SnapshotRef> { self.current_snapshot_id.map(