odysa opened a new pull request, #196:
URL: https://github.com/apache/iceberg-rust/pull/196
Remove `unwrap` and `expect`.
It looks like some `expect` are expected.
For example
```rust
pub fn current_snapshot(&self) -> Option<&SnapshotRef> {
self.current_snapshot_id.map(|s| {
self.snapshot_by_id(s)
.expect("Current snapshot id has been set, but doesn't exist
in metadata")
})
}
```
I tried to remove this `expect` in this PR and there will not be an error
message.
Do we expect panic here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
