Fokko merged PR #356:
URL: https://github.com/apache/iceberg-python/pull/356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
Fokko commented on code in PR #356:
URL: https://github.com/apache/iceberg-python/pull/356#discussion_r1477447763
##
pyiceberg/catalog/sql.py:
##
@@ -111,7 +111,7 @@ def _ensure_tables_exist(self) -> None:
stmt = select(1).select_from(table)
try
Fokko commented on PR #356:
URL: https://github.com/apache/iceberg-python/pull/356#issuecomment-1925907114
@rahij Sure thing! Can you run `make lint` to fix the style issues? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
rahij commented on PR #356:
URL: https://github.com/apache/iceberg-python/pull/356#issuecomment-1925250020
@Fokko would you be the right person to review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
rahij opened a new pull request, #356:
URL: https://github.com/apache/iceberg-python/pull/356
When sqlalchemy encounters an error if the table does not exist, it raises a
different exception from sqlite. Hence, when using postgres, it is not possible
to even create the catalog, as the excep