Fokko commented on code in PR #356:
URL: https://github.com/apache/iceberg-python/pull/356#discussion_r1477447763
##########
pyiceberg/catalog/sql.py:
##########
@@ -111,7 +111,7 @@ def _ensure_tables_exist(self) -> None:
stmt = select(1).select_from(table)
try:
session.scalar(stmt)
- except OperationalError:
+ except (OperationalError, ProgrammingError): # sqlalchemy
returns OperationalError in case of sqlite and ProgrammingError with postgres.
Review Comment:
```suggestion
except (
OperationalError,
ProgrammingError,
): # sqlalchemy returns OperationalError in case of sqlite
and ProgrammingError with postgres.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
