Re: [PR] fix: renaming FileScanTask.data_file to data_manifest_entry [iceberg-rust]

2024-03-26 Thread via GitHub
liurenjie1024 merged PR #300: URL: https://github.com/apache/iceberg-rust/pull/300 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] fix: renaming FileScanTask.data_file to data_manifest_entry [iceberg-rust]

2024-03-26 Thread via GitHub
marvinlanhenke commented on code in PR #300: URL: https://github.com/apache/iceberg-rust/pull/300#discussion_r1538858222 ## crates/iceberg/src/scan.rs: ## @@ -209,8 +209,8 @@ pub struct FileScanTask { pub type ArrowRecordBatchStream = BoxStream<'static, crate::Result>; impl

Re: [PR] fix: renaming FileScanTask.data_file to data_manifest_entry [iceberg-rust]

2024-03-26 Thread via GitHub
liurenjie1024 commented on code in PR #300: URL: https://github.com/apache/iceberg-rust/pull/300#discussion_r1538830097 ## crates/iceberg/src/scan.rs: ## @@ -209,8 +209,8 @@ pub struct FileScanTask { pub type ArrowRecordBatchStream = BoxStream<'static, crate::Result>; impl

[PR] fix: renaming FileScanTask.data_file to data_manifest_entry [iceberg-rust]

2024-03-25 Thread via GitHub
a-agmon opened a new pull request, #300: URL: https://github.com/apache/iceberg-rust/pull/300 resolves: #299 This PR is: 1. Renames FileScanTask.data_file to data_manifest_entry (it returns `ManifestEntry`) 2. Exposes data_file() on `ManifestEntry` 3. change access to d