liurenjie1024 commented on code in PR #300:
URL: https://github.com/apache/iceberg-rust/pull/300#discussion_r1538830097
##########
crates/iceberg/src/scan.rs:
##########
@@ -209,8 +209,8 @@ pub struct FileScanTask {
pub type ArrowRecordBatchStream = BoxStream<'static,
crate::Result<RecordBatch>>;
impl FileScanTask {
- pub fn data_file(&self) -> ManifestEntryRef {
- self.data_file.clone()
+ pub fn data_manifest_entry(&self) -> ManifestEntryRef {
Review Comment:
```suggestion
pub fn data(&self) -> ManifestEntryRef {
```
How about just naming it as `data`? cc @marvinlanhenke What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
