Re: [PR] fix: fix delete files sequence comparison [iceberg-rust]

2025-03-18 Thread via GitHub
liurenjie1024 merged PR #1077: URL: https://github.com/apache/iceberg-rust/pull/1077 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] fix: fix delete files sequence comparison [iceberg-rust]

2025-03-17 Thread via GitHub
chenzl25 commented on code in PR #1077: URL: https://github.com/apache/iceberg-rust/pull/1077#discussion_r291436 ## crates/iceberg/src/delete_file_index.rs: ## @@ -147,21 +147,21 @@ impl PopulatedDeleteFileIndex { self.global_deletes .iter() -

Re: [PR] fix: fix delete files sequence comparison [iceberg-rust]

2025-03-16 Thread via GitHub
liurenjie1024 commented on code in PR #1077: URL: https://github.com/apache/iceberg-rust/pull/1077#discussion_r1997841417 ## crates/iceberg/src/delete_file_index.rs: ## @@ -147,21 +147,21 @@ impl PopulatedDeleteFileIndex { self.global_deletes .iter() -

Re: [PR] fix: fix delete files sequence comparison [iceberg-rust]

2025-03-12 Thread via GitHub
chenzl25 commented on code in PR #1077: URL: https://github.com/apache/iceberg-rust/pull/1077#discussion_r1992778027 ## crates/iceberg/src/delete_file_index.rs: ## @@ -147,21 +147,21 @@ impl PopulatedDeleteFileIndex { self.global_deletes .iter() -

Re: [PR] fix: fix delete files sequence comparison [iceberg-rust]

2025-03-12 Thread via GitHub
chenzl25 commented on code in PR #1077: URL: https://github.com/apache/iceberg-rust/pull/1077#discussion_r1992778027 ## crates/iceberg/src/delete_file_index.rs: ## @@ -147,21 +147,21 @@ impl PopulatedDeleteFileIndex { self.global_deletes .iter() -

Re: [PR] fix: fix delete files sequence comparison [iceberg-rust]

2025-03-12 Thread via GitHub
liurenjie1024 commented on code in PR #1077: URL: https://github.com/apache/iceberg-rust/pull/1077#discussion_r1992561376 ## crates/iceberg/src/delete_file_index.rs: ## @@ -147,21 +147,21 @@ impl PopulatedDeleteFileIndex { self.global_deletes .iter() -

[PR] fix: fix delete files sequence comparison [iceberg-rust]

2025-03-12 Thread via GitHub
chenzl25 opened a new pull request, #1077: URL: https://github.com/apache/iceberg-rust/pull/1077 ## Which issue does this PR close? - Closes #. ## What changes are included in this PR? - Fix delete files sequence comparison. - For position delete, its sequence