liurenjie1024 commented on code in PR #1077:
URL: https://github.com/apache/iceberg-rust/pull/1077#discussion_r1997841417
##########
crates/iceberg/src/delete_file_index.rs:
##########
@@ -147,21 +147,21 @@ impl PopulatedDeleteFileIndex {
self.global_deletes
.iter()
- // filter that returns true if the provided delete file's sequence
number is **greater than or equal to** `seq_num`
+ // filter that returns true if the provided delete file's sequence
number is **greater than** `seq_num`
.filter(|&delete| {
seq_num
- .map(|seq_num| delete.manifest_entry.sequence_number() >=
Some(seq_num))
+ .map(|seq_num| delete.manifest_entry.sequence_number() >
Some(seq_num))
Review Comment:
I think the `global_deletes` is supposed to contain all deletion files, and
this will lead to incorrect behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
