kaushiksrini commented on PR #1772:
URL: https://github.com/apache/iceberg-python/pull/1772#issuecomment-2864831706
@sungwy, I implemented your feedback in the PR. Let me know what you think!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
kaushiksrini commented on PR #1772:
URL: https://github.com/apache/iceberg-python/pull/1772#issuecomment-2816738548
Hey @sungwy thanks for the review! Will address the feedback soon - I will
also take a look at the subtasks and would like to work on them!
--
This is an automated message f
sungwy commented on PR #1772:
URL: https://github.com/apache/iceberg-python/pull/1772#issuecomment-2814294884
I've created some subtasks on
https://github.com/apache/iceberg-python/issues/819 that will help us implement
the required validation functions that we can invoke to check that no
Fokko commented on code in PR #1772:
URL: https://github.com/apache/iceberg-python/pull/1772#discussion_r2050541351
##
pyiceberg/table/update/snapshot.py:
##
@@ -279,6 +296,30 @@ def _commit(self) -> UpdatesAndRequirements:
(AssertRefSnapshotId(snapshot_id=self._tr
Fokko commented on code in PR #1772:
URL: https://github.com/apache/iceberg-python/pull/1772#discussion_r2050541351
##
pyiceberg/table/update/snapshot.py:
##
@@ -279,6 +296,30 @@ def _commit(self) -> UpdatesAndRequirements:
(AssertRefSnapshotId(snapshot_id=self._tr
sungwy commented on code in PR #1772:
URL: https://github.com/apache/iceberg-python/pull/1772#discussion_r2049778093
##
tests/integration/test_add_files.py:
##
@@ -850,3 +850,70 @@ def
test_add_files_that_referenced_by_current_snapshot_with_check_duplicate_file
with pytest
Fokko commented on code in PR #1772:
URL: https://github.com/apache/iceberg-python/pull/1772#discussion_r2006279768
##
pyiceberg/utils/snapshot.py:
##
@@ -0,0 +1,53 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See
Fokko commented on code in PR #1772:
URL: https://github.com/apache/iceberg-python/pull/1772#discussion_r2006284761
##
pyiceberg/table/update/snapshot.py:
##
@@ -251,6 +253,13 @@ def _commit(self) -> UpdatesAndRequirements:
)
location_provider = self._transacti
Fokko commented on PR #1772:
URL: https://github.com/apache/iceberg-python/pull/1772#issuecomment-2740745140
Let's add some tests as well:
```python
@pytest.mark.integration
@pytest.mark.parametrize("format_version", [1, 2])
def test_conflict(
spark: SparkSession, sessi
Fokko commented on PR #1772:
URL: https://github.com/apache/iceberg-python/pull/1772#issuecomment-2740743985
@kaushiksrini can you check the CI? It looks like `mypy` has some issues:
```
pyiceberg/table/update/snapshot.py:303: error: Item "None" of "Snapshot |
None" has no attribut
Fokko commented on code in PR #1772:
URL: https://github.com/apache/iceberg-python/pull/1772#discussion_r2005832177
##
pyiceberg/table/update/snapshot.py:
##
@@ -251,6 +253,13 @@ def _commit(self) -> UpdatesAndRequirements:
)
location_provider = self._transacti
kaushiksrini commented on code in PR #1772:
URL: https://github.com/apache/iceberg-python/pull/1772#discussion_r2005787964
##
pyiceberg/table/update/snapshot.py:
##
@@ -251,6 +253,13 @@ def _commit(self) -> UpdatesAndRequirements:
)
location_provider = self._tr
Fokko commented on code in PR #1772:
URL: https://github.com/apache/iceberg-python/pull/1772#discussion_r2005775099
##
pyiceberg/table/update/snapshot.py:
##
@@ -251,6 +253,13 @@ def _commit(self) -> UpdatesAndRequirements:
)
location_provider = self._transacti
Fokko commented on code in PR #1772:
URL: https://github.com/apache/iceberg-python/pull/1772#discussion_r1986237088
##
pyiceberg/utils/snapshot.py:
##
@@ -0,0 +1,53 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See
kaushiksrini opened a new pull request, #1772:
URL: https://github.com/apache/iceberg-python/pull/1772
## Description
- This PR checks snapshot write compatibility and validates no conflicting
concurrent operations have been written that can clash.
- Added Snapshot util file that i
15 matches
Mail list logo
