kaushiksrini commented on code in PR #1772:
URL: https://github.com/apache/iceberg-python/pull/1772#discussion_r2005787964
##########
pyiceberg/table/update/snapshot.py:
##########
@@ -251,6 +253,13 @@ def _commit(self) -> UpdatesAndRequirements:
)
location_provider = self._transaction._table.location_provider()
manifest_list_file_path =
location_provider.new_metadata_location(file_name)
+
+ # get current snapshot id and starting snapshot id, and validate that
there are no conflicts
+ if self._transaction._table.__class__.__name__ != "StagedTable":
Review Comment:
@Fokko, I tried this however by importing `StagedTable` to this file I
create a cyclical import dependency. Any recommendations on how to solve this?
Need to check this since `StagedTable` class doesn't override the `refresh()`
function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
