kevinjqliu commented on PR #1464:
URL: https://github.com/apache/iceberg-python/pull/1464#issuecomment-2652655967
rebased off main and fixed the tests.
Thanks @IndexSeek for the contribution and @Fokko for the review :)
--
This is an automated message from the Apache Git Service.
kevinjqliu merged PR #1464:
URL: https://github.com/apache/iceberg-python/pull/1464
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@i
kevinjqliu commented on PR #1464:
URL: https://github.com/apache/iceberg-python/pull/1464#issuecomment-2632146125
its an issue with dead url link, i think rebasing `main` should resolve it.
Also, do you think its important to include a warning about accidentally
checking in secrets w
Fokko commented on PR #1464:
URL: https://github.com/apache/iceberg-python/pull/1464#issuecomment-2632078842
@IndexSeek It looks like the CI is still a bit sad, do you have a minute to
look at this?
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
IndexSeek commented on PR #1464:
URL: https://github.com/apache/iceberg-python/pull/1464#issuecomment-2629027304
> hey @IndexSeek could you rebase this PR and run `make lint`? would be
great to include this as part of the 0.9.0 release
I just rebased and pre-commit is passing. Please
kevinjqliu commented on PR #1464:
URL: https://github.com/apache/iceberg-python/pull/1464#issuecomment-2628597206
hey @IndexSeek could you rebase this PR and run `make lint`? would be great
to include this as part of the 0.9.0 release
--
This is an automated message from the Apache Git S
kevinjqliu commented on code in PR #1464:
URL: https://github.com/apache/iceberg-python/pull/1464#discussion_r1901245337
##
mkdocs/docs/api.md:
##
@@ -49,7 +49,7 @@ catalog:
and loaded in python by calling `load_catalog(name="hive")` and
`load_catalog(name="rest")`.
-This
IndexSeek commented on PR #1464:
URL: https://github.com/apache/iceberg-python/pull/1464#issuecomment-2564799798
> I've left one comment, but apart from that, it looks good to me 👍
Thank you! I applied that change! ✅
--
This is an automated message from the Apache Git Service.
To r
Fokko commented on code in PR #1464:
URL: https://github.com/apache/iceberg-python/pull/1464#discussion_r1899066825
##
mkdocs/docs/cli.md:
##
@@ -26,7 +26,7 @@ hide:
Pyiceberg comes with a CLI that's available after installing the `pyiceberg`
package.
-You can pass the pat
IndexSeek commented on PR #1464:
URL: https://github.com/apache/iceberg-python/pull/1464#issuecomment-2562875425
There's another test that looks to do something similar to this newer test.
Are both needed?
https://github.com/apache/iceberg-python/blob/0e5086ceb77351bc0b6ec3a592f5eda7
IndexSeek commented on code in PR #1464:
URL: https://github.com/apache/iceberg-python/pull/1464#discussion_r1897973076
##
tests/utils/test_config.py:
##
@@ -93,3 +94,61 @@ def
test_from_configuration_files_get_typed_value(tmp_path_factory: pytest.TempP
assert Config().g
IndexSeek commented on code in PR #1464:
URL: https://github.com/apache/iceberg-python/pull/1464#discussion_r1897972928
##
tests/utils/test_config.py:
##
@@ -93,3 +94,61 @@ def
test_from_configuration_files_get_typed_value(tmp_path_factory: pytest.TempP
assert Config().g
kevinjqliu commented on code in PR #1464:
URL: https://github.com/apache/iceberg-python/pull/1464#discussion_r1896047664
##
tests/utils/test_config.py:
##
@@ -93,3 +94,61 @@ def
test_from_configuration_files_get_typed_value(tmp_path_factory: pytest.TempP
assert Config().
IndexSeek commented on code in PR #1464:
URL: https://github.com/apache/iceberg-python/pull/1464#discussion_r1895072573
##
pyiceberg/utils/config.py:
##
Review Comment:
I tried adding a test here, but I wonder if there are opportunities to clean
it up.
--
This is an a
IndexSeek commented on code in PR #1464:
URL: https://github.com/apache/iceberg-python/pull/1464#discussion_r1895072366
##
mkdocs/docs/configuration.md:
##
Review Comment:
Nice finds! That grep tool is pretty neat. I just made some corrections to
these in
https://github.c
IndexSeek commented on code in PR #1464:
URL: https://github.com/apache/iceberg-python/pull/1464#discussion_r1895072054
##
pyiceberg/utils/config.py:
##
@@ -84,12 +84,13 @@ def _load_yaml(directory: Optional[str]) ->
Optional[RecursiveDict]:
return file_con
kevinjqliu commented on code in PR #1464:
URL: https://github.com/apache/iceberg-python/pull/1464#discussion_r1895062991
##
pyiceberg/utils/config.py:
##
@@ -84,12 +84,13 @@ def _load_yaml(directory: Optional[str]) ->
Optional[RecursiveDict]:
return file_co
IndexSeek opened a new pull request, #1464:
URL: https://github.com/apache/iceberg-python/pull/1464
Resolves #1333
Adds the current working directory to the search path for the
`.pyiceberg.yaml` file.
As it is now, the file is searched in the following order:
1. the `PYICE
18 matches
Mail list logo
