kevinjqliu commented on code in PR #1464:
URL: https://github.com/apache/iceberg-python/pull/1464#discussion_r1895062991
##########
pyiceberg/utils/config.py:
##########
@@ -84,12 +84,13 @@ def _load_yaml(directory: Optional[str]) ->
Optional[RecursiveDict]:
return file_config_lowercase
return None
- # Give priority to the PYICEBERG_HOME directory
- if pyiceberg_home_config := _load_yaml(os.environ.get(PYICEBERG_HOME)):
- return pyiceberg_home_config
- # Look into the home directory
- if pyiceberg_home_config := _load_yaml(os.path.expanduser("~")):
- return pyiceberg_home_config
+ # Directories to search for the configuration file
Review Comment:
nit: i like the comment on search order "PYICEBERG_HOME, home directory,
then current directory"
##########
mkdocs/docs/configuration.md:
##########
Review Comment:
there are a couple other places where pyiceberg.yaml is referenced in the
docs
https://grep.app/search?q=pyiceberg.yaml&filter[repo][0]=apache/iceberg-python&filter[path][0]=mkdocs/docs/
##########
pyiceberg/utils/config.py:
##########
Review Comment:
nit: also add test
https://grep.app/search?q=pyiceberg.yaml&filter[repo][0]=apache/iceberg-python&filter[path][0]=tests/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
