Fokko merged PR #113:
URL: https://github.com/apache/iceberg-cpp/pull/113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
wgtmac commented on code in PR #113:
URL: https://github.com/apache/iceberg-cpp/pull/113#discussion_r2125320434
##
src/iceberg/arrow/arrow_fs_file_io.h:
##
@@ -46,6 +46,9 @@ class ICEBERG_BUNDLE_EXPORT ArrowFileSystemFileIO : public
FileIO {
/// \brief Delete a file at the g
wgtmac commented on code in PR #113:
URL: https://github.com/apache/iceberg-cpp/pull/113#discussion_r2125288754
##
src/iceberg/avro/avro_reader.cc:
##
@@ -0,0 +1,222 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.
wgtmac commented on code in PR #113:
URL: https://github.com/apache/iceberg-cpp/pull/113#discussion_r2125286726
##
src/iceberg/avro/avro_reader.cc:
##
@@ -0,0 +1,222 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.
Fokko commented on code in PR #113:
URL: https://github.com/apache/iceberg-cpp/pull/113#discussion_r2124737995
##
src/iceberg/avro/avro_reader.cc:
##
@@ -0,0 +1,222 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.
mapleFU commented on PR #113:
URL: https://github.com/apache/iceberg-cpp/pull/113#issuecomment-2935121277
We can just move forward fast and leave this as a minor todo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
wgtmac commented on PR #113:
URL: https://github.com/apache/iceberg-cpp/pull/113#issuecomment-2935107822
@mapleFU Sounds good. I think the current implementation aims to provide a
minimal Avro reader implementation. We can revisit this once we have complete
Avro and Parquet reader impls and
mapleFU commented on PR #113:
URL: https://github.com/apache/iceberg-cpp/pull/113#issuecomment-2934673162
Personally I prefer set a internal `status_` when error happens, and when
`Next` is called, internal `status_` is checked before doing operations. Since
this is generally a batch interf
Xuanwo commented on PR #113:
URL: https://github.com/apache/iceberg-cpp/pull/113#issuecomment-2934289267
cc @mapleFU would you like to take another look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
lidavidm commented on code in PR #113:
URL: https://github.com/apache/iceberg-cpp/pull/113#discussion_r2115790873
##
src/iceberg/expected.h:
##
@@ -122,7 +122,7 @@ inline constexpr bool is_error_type_valid_v =
is_error_type_valid::value;
} // namespace expected_detail
temp
wgtmac commented on code in PR #113:
URL: https://github.com/apache/iceberg-cpp/pull/113#discussion_r2115528845
##
src/iceberg/expected.h:
##
@@ -122,7 +122,7 @@ inline constexpr bool is_error_type_valid_v =
is_error_type_valid::value;
} // namespace expected_detail
templa
wgtmac commented on code in PR #113:
URL: https://github.com/apache/iceberg-cpp/pull/113#discussion_r2115392858
##
src/iceberg/avro/avro_reader.cc:
##
@@ -0,0 +1,222 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.
mapleFU commented on code in PR #113:
URL: https://github.com/apache/iceberg-cpp/pull/113#discussion_r2115398710
##
src/iceberg/avro/avro_reader.cc:
##
@@ -0,0 +1,222 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements
wgtmac commented on code in PR #113:
URL: https://github.com/apache/iceberg-cpp/pull/113#discussion_r2115396425
##
src/iceberg/avro/avro_reader.cc:
##
@@ -0,0 +1,222 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.
wgtmac commented on code in PR #113:
URL: https://github.com/apache/iceberg-cpp/pull/113#discussion_r2115395582
##
src/iceberg/avro/avro_reader.cc:
##
@@ -0,0 +1,222 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.
wgtmac commented on code in PR #113:
URL: https://github.com/apache/iceberg-cpp/pull/113#discussion_r2115393660
##
src/iceberg/avro/avro_data_util.cc:
##
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreement
mapleFU commented on code in PR #113:
URL: https://github.com/apache/iceberg-cpp/pull/113#discussion_r2115383164
##
src/iceberg/avro/avro_reader.cc:
##
@@ -0,0 +1,222 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements
lidavidm commented on code in PR #113:
URL: https://github.com/apache/iceberg-cpp/pull/113#discussion_r2115359723
##
src/iceberg/avro/avro_reader.cc:
##
@@ -0,0 +1,222 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreement
wgtmac opened a new pull request, #113:
URL: https://github.com/apache/iceberg-cpp/pull/113
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
19 matches
Mail list logo
