wgtmac commented on code in PR #113:
URL: https://github.com/apache/iceberg-cpp/pull/113#discussion_r2115528845
##########
src/iceberg/expected.h:
##########
@@ -122,7 +122,7 @@ inline constexpr bool is_error_type_valid_v =
is_error_type_valid<T>::value;
} // namespace expected_detail
template <class E>
-class ICEBERG_EXPORT [[nodiscard]] unexpected {
Review Comment:
I have to remove these to fix
https://github.com/apache/iceberg-cpp/actions/runs/15342734208/job/43172206905.
I think adding `ICEBERG_EXPORT` here makes all `Result<E>` defined in the
`libiceberg-bundle` as import symbols and the linker cannot find them
anywhere. @zhjwpku @lidavidm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
