Re: [PR] feat: avro support applying field-ids based on name mapping [iceberg-cpp]

wgtmac commented on code in PR #127: URL: https://github.com/apache/iceberg-cpp/pull/127#discussion_r2174062567 ## src/iceberg/file_reader.h: ## @@ -29,6 +29,7 @@ #include "iceberg/arrow_c_data.h" #include "iceberg/file_format.h" +#include "iceberg/name_mapping.h" Review Co

Re: [PR] feat: avro support applying field-ids based on name mapping [iceberg-cpp]

MisterRaindrop commented on code in PR #127: URL: https://github.com/apache/iceberg-cpp/pull/127#discussion_r2174050358 ## src/iceberg/avro/avro_reader.cc: ## @@ -195,6 +209,147 @@ class AvroBatchReader::Impl { return arrow_array; } + // Apply field IDs to Avro schema

Re: [PR] feat: avro support applying field-ids based on name mapping [iceberg-cpp]

wgtmac commented on code in PR #127: URL: https://github.com/apache/iceberg-cpp/pull/127#discussion_r2173344474 ## src/iceberg/avro/avro_reader.cc: ## @@ -96,11 +99,22 @@ class AvroBatchReader::Impl { // Validate field ids in the file schema. HasIdVisitor has_id_visito

Re: [PR] feat: avro support applying field-ids based on name mapping [iceberg-cpp]

MisterRaindrop commented on code in PR #127: URL: https://github.com/apache/iceberg-cpp/pull/127#discussion_r2173277246 ## src/iceberg/avro/avro_reader.cc: ## @@ -96,11 +99,22 @@ class AvroBatchReader::Impl { // Validate field ids in the file schema. HasIdVisitor has_i

Re: [PR] feat: avro support applying field-ids based on name mapping [iceberg-cpp]

MisterRaindrop commented on code in PR #127: URL: https://github.com/apache/iceberg-cpp/pull/127#discussion_r2173277246 ## src/iceberg/avro/avro_reader.cc: ## @@ -96,11 +99,22 @@ class AvroBatchReader::Impl { // Validate field ids in the file schema. HasIdVisitor has_i

Re: [PR] feat: avro support applying field-ids based on name mapping [iceberg-cpp]

wgtmac commented on code in PR #127: URL: https://github.com/apache/iceberg-cpp/pull/127#discussion_r2163185837 ## src/iceberg/CMakeLists.txt: ## @@ -98,7 +98,8 @@ if(ICEBERG_BUILD_BUNDLE) avro/avro_data_util.cc avro/avro_reader.cc avro/avro_schema_util.cc -

Re: [PR] feat: avro support applying field-ids based on name mapping [iceberg-cpp]

mapleFU commented on code in PR #127: URL: https://github.com/apache/iceberg-cpp/pull/127#discussion_r2163038798 ## src/iceberg/avro/avro_reader.cc: ## @@ -96,11 +99,22 @@ class AvroBatchReader::Impl { // Validate field ids in the file schema. HasIdVisitor has_id_visit

Re: [PR] feat: avro support applying field-ids based on name mapping [iceberg-cpp]

MisterRaindrop commented on code in PR #127: URL: https://github.com/apache/iceberg-cpp/pull/127#discussion_r2166845335 ## src/iceberg/avro/avro_reader.cc: ## @@ -96,11 +99,22 @@ class AvroBatchReader::Impl { // Validate field ids in the file schema. HasIdVisitor has_i

Re: [PR] feat: avro support applying field-ids based on name mapping [iceberg-cpp]

mapleFU commented on code in PR #127: URL: https://github.com/apache/iceberg-cpp/pull/127#discussion_r2163038104 ## src/iceberg/avro/avro_reader.cc: ## @@ -96,11 +99,22 @@ class AvroBatchReader::Impl { // Validate field ids in the file schema. HasIdVisitor has_id_visit

Re: [PR] feat: avro support applying field-ids based on name mapping [iceberg-cpp]

MisterRaindrop commented on code in PR #127: URL: https://github.com/apache/iceberg-cpp/pull/127#discussion_r2163004896 ## src/iceberg/CMakeLists.txt: ## @@ -98,7 +98,8 @@ if(ICEBERG_BUILD_BUNDLE) avro/avro_data_util.cc avro/avro_reader.cc avro/avro_schema_u

Re: [PR] feat: avro support applying field-ids based on name mapping [iceberg-cpp]

MisterRaindrop commented on code in PR #127: URL: https://github.com/apache/iceberg-cpp/pull/127#discussion_r2163003327 ## src/iceberg/CMakeLists.txt: ## @@ -98,7 +98,8 @@ if(ICEBERG_BUILD_BUNDLE) avro/avro_data_util.cc avro/avro_reader.cc avro/avro_schema_u

Re: [PR] feat: avro support applying field-ids based on name mapping [iceberg-cpp]

wgtmac commented on code in PR #127: URL: https://github.com/apache/iceberg-cpp/pull/127#discussion_r2162828781 ## src/iceberg/CMakeLists.txt: ## @@ -98,7 +98,8 @@ if(ICEBERG_BUILD_BUNDLE) avro/avro_data_util.cc avro/avro_reader.cc avro/avro_schema_util.cc -