MisterRaindrop commented on code in PR #127:
URL: https://github.com/apache/iceberg-cpp/pull/127#discussion_r2163004896
##########
src/iceberg/CMakeLists.txt:
##########
@@ -98,7 +98,8 @@ if(ICEBERG_BUILD_BUNDLE)
avro/avro_data_util.cc
avro/avro_reader.cc
avro/avro_schema_util.cc
- avro/avro_stream_internal.cc)
+ avro/avro_stream_internal.cc
+ json_internal.cc)
Review Comment:
I'm confused. Parsing name_mapping requires json function. But the method is
defined in the json_internal.cc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
