liurenjie1024 merged PR #677:
URL: https://github.com/apache/iceberg-rust/pull/677
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
Xuanwo commented on PR #677:
URL: https://github.com/apache/iceberg-rust/pull/677#issuecomment-2437301516
Thank you @sundy-li for this work, also thanks @liurenjie1024's review and
@sdd for fixing CI, we are fine to merge now.
--
This is an automated message from the Apache Git Service.
T
sdd commented on PR #677:
URL: https://github.com/apache/iceberg-rust/pull/677#issuecomment-2436019488
@Xuanwo I've got a fix for that build issue here:
https://github.com/apache/iceberg-rust/pull/680
--
This is an automated message from the Apache Git Service.
To respond to the message,
Xuanwo commented on PR #677:
URL: https://github.com/apache/iceberg-rust/pull/677#issuecomment-2434822386
Seems related opendal's new release, I will get it fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
liurenjie1024 commented on code in PR #677:
URL: https://github.com/apache/iceberg-rust/pull/677#discussion_r1812387339
##
crates/iceberg/src/scan.rs:
##
@@ -394,6 +411,11 @@ impl TableScan {
return Ok(file_scan_task_rx.boxed());
}
+/// Returns an [`ManifestL
sundy-li commented on PR #677:
URL: https://github.com/apache/iceberg-rust/pull/677#issuecomment-2431341044
> This looks good to me, thanks! I'm assuming that the reason why someone
would want to perform a scan with an empty projection is to get a row count?
As I described in the issu
Xuanwo commented on code in PR #677:
URL: https://github.com/apache/iceberg-rust/pull/677#discussion_r1812233893
##
crates/iceberg/src/scan.rs:
##
@@ -394,6 +411,11 @@ impl TableScan {
return Ok(file_scan_task_rx.boxed());
}
+/// Returns an [`ManifestList`]
+
sundy-li commented on code in PR #677:
URL: https://github.com/apache/iceberg-rust/pull/677#discussion_r1812226077
##
crates/iceberg/src/arrow/record_batch_transformer.rs:
##
@@ -154,10 +142,15 @@ impl RecordBatchTransformer {
Some(BatchTransform::Modify {
sundy-li commented on code in PR #677:
URL: https://github.com/apache/iceberg-rust/pull/677#discussion_r1812219171
##
crates/iceberg/src/scan.rs:
##
@@ -394,6 +411,11 @@ impl TableScan {
return Ok(file_scan_task_rx.boxed());
}
+/// Returns an [`ManifestList`]
liurenjie1024 commented on code in PR #677:
URL: https://github.com/apache/iceberg-rust/pull/677#discussion_r1812028265
##
crates/iceberg/src/scan.rs:
##
@@ -394,6 +411,11 @@ impl TableScan {
return Ok(file_scan_task_rx.boxed());
}
+/// Returns an [`ManifestL
sdd commented on PR #677:
URL: https://github.com/apache/iceberg-rust/pull/677#issuecomment-2431040483
This looks good to me, thanks! I'm assuming that the reason why someone
would want to perform a scan with an empty projection is to get a row count?
--
This is an automated message f
Xuanwo commented on PR #677:
URL: https://github.com/apache/iceberg-rust/pull/677#issuecomment-2426159060
Failure in CI should be fixed by
https://github.com/apache/iceberg-rust/pull/678
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
12 matches
Mail list logo
