liurenjie1024 commented on code in PR #677:
URL: https://github.com/apache/iceberg-rust/pull/677#discussion_r1812028265
##########
crates/iceberg/src/scan.rs:
##########
@@ -394,6 +411,11 @@ impl TableScan {
return Ok(file_scan_task_rx.boxed());
}
+ /// Returns an [`ManifestList`]
+ pub async fn get_manifest_list(&self) -> Result<Arc<ManifestList>> {
Review Comment:
Where is this used?
##########
crates/iceberg/src/arrow/record_batch_transformer.rs:
##########
@@ -154,10 +142,15 @@ impl RecordBatchTransformer {
Some(BatchTransform::Modify {
ref target_schema,
ref operations,
- }) => RecordBatch::try_new(
- target_schema.clone(),
- self.transform_columns(record_batch.columns(), operations)?,
- )?,
+ }) => {
+ let options =
Review Comment:
Did we verify that this code path? I assume that it the operations may fail
with empty array?
##########
crates/iceberg/src/scan.rs:
##########
@@ -51,8 +51,8 @@ pub type ArrowRecordBatchStream = BoxStream<'static,
Result<RecordBatch>>;
/// Builder to create table scan.
pub struct TableScanBuilder<'a> {
table: &'a Table,
- // Empty column names means to select all columns
- column_names: Vec<String>,
+ // defaults to none which means select all columns
Review Comment:
```suggestion
// Defaults to none which means select all columns
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
