Re: [PR] feat: add manifest related structures [iceberg-cpp]

Fokko merged PR #91: URL: https://github.com/apache/iceberg-cpp/pull/91 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach

Re: [PR] feat: add manifest related structures [iceberg-cpp]

Fokko commented on PR #91: URL: https://github.com/apache/iceberg-cpp/pull/91#issuecomment-2895504012 Thanks @zhjwpku for adding this, and thanks @wgtmac and @gty404 for the review 🙌 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] feat: add manifest related structures [iceberg-cpp]

zhjwpku commented on code in PR #91: URL: https://github.com/apache/iceberg-cpp/pull/91#discussion_r2098093696 ## src/iceberg/manifest_list.h: ## @@ -0,0 +1,202 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] feat: add manifest related structures [iceberg-cpp]

zhjwpku commented on code in PR #91: URL: https://github.com/apache/iceberg-cpp/pull/91#discussion_r2097626250 ## src/iceberg/manifest_list.h: ## @@ -0,0 +1,235 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] feat: add manifest related structures [iceberg-cpp]

Fokko commented on code in PR #91: URL: https://github.com/apache/iceberg-cpp/pull/91#discussion_r2095503674 ## src/iceberg/manifest_list.h: ## @@ -0,0 +1,235 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See t

Re: [PR] feat: add manifest related structures [iceberg-cpp]

Fokko commented on code in PR #91: URL: https://github.com/apache/iceberg-cpp/pull/91#discussion_r2095505522 ## src/iceberg/manifest_list.h: ## @@ -0,0 +1,235 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See t

Re: [PR] feat: add manifest related structures [iceberg-cpp]

Fokko commented on code in PR #91: URL: https://github.com/apache/iceberg-cpp/pull/91#discussion_r2095504702 ## src/iceberg/manifest_list.h: ## @@ -0,0 +1,235 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See t

Re: [PR] feat: add manifest related structures [iceberg-cpp]

Fokko commented on code in PR #91: URL: https://github.com/apache/iceberg-cpp/pull/91#discussion_r2095483228 ## src/iceberg/manifest_list.h: ## @@ -0,0 +1,202 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See t

Re: [PR] feat: add manifest related structures [iceberg-cpp]

Fokko commented on code in PR #91: URL: https://github.com/apache/iceberg-cpp/pull/91#discussion_r2095483228 ## src/iceberg/manifest_list.h: ## @@ -0,0 +1,202 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See t

Re: [PR] feat: add manifest related structures [iceberg-cpp]

zhjwpku commented on code in PR #91: URL: https://github.com/apache/iceberg-cpp/pull/91#discussion_r2086984056 ## src/iceberg/manifest_list.cc: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] feat: add manifest related structures [iceberg-cpp]

zhjwpku commented on code in PR #91: URL: https://github.com/apache/iceberg-cpp/pull/91#discussion_r2086955048 ## src/iceberg/schema_field.h: ## @@ -86,4 +86,16 @@ class ICEBERG_EXPORT SchemaField : public iceberg::util::Formattable { bool optional_; }; +template +inline

Re: [PR] feat: add manifest related structures [iceberg-cpp]

wgtmac commented on code in PR #91: URL: https://github.com/apache/iceberg-cpp/pull/91#discussion_r2085835400 ## src/iceberg/schema_field.h: ## @@ -86,4 +86,16 @@ class ICEBERG_EXPORT SchemaField : public iceberg::util::Formattable { bool optional_; }; +template +inline

Re: [PR] feat: add manifest related structures [iceberg-cpp]

zhjwpku commented on code in PR #91: URL: https://github.com/apache/iceberg-cpp/pull/91#discussion_r2084834432 ## src/iceberg/manifest_entry.h: ## @@ -0,0 +1,256 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. Se

Re: [PR] feat: add manifest related structures [iceberg-cpp]

wgtmac commented on code in PR #91: URL: https://github.com/apache/iceberg-cpp/pull/91#discussion_r2084008713 ## src/iceberg/schema_field.h: ## @@ -86,4 +86,16 @@ class ICEBERG_EXPORT SchemaField : public iceberg::util::Formattable { bool optional_; }; +template +inline

Re: [PR] feat: add manifest related structures [iceberg-cpp]

wgtmac commented on code in PR #91: URL: https://github.com/apache/iceberg-cpp/pull/91#discussion_r2083942933 ## src/iceberg/manifest_entry.cc: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] feat: add manifest related structures [iceberg-cpp]

lidavidm commented on code in PR #91: URL: https://github.com/apache/iceberg-cpp/pull/91#discussion_r2083647799 ## src/iceberg/manifest_entry.cc: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. S

Re: [PR] feat: add manifest related structures [iceberg-cpp]

wgtmac commented on code in PR #91: URL: https://github.com/apache/iceberg-cpp/pull/91#discussion_r2083555468 ## src/iceberg/manifest_entry.h: ## @@ -0,0 +1,256 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] feat: add manifest related structures [iceberg-cpp]

zhjwpku commented on code in PR #91: URL: https://github.com/apache/iceberg-cpp/pull/91#discussion_r2083026964 ## src/iceberg/manifest_list.cc: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. Se

Re: [PR] feat: add manifest related structures [iceberg-cpp]

zhjwpku commented on code in PR #91: URL: https://github.com/apache/iceberg-cpp/pull/91#discussion_r2082810322 ## src/iceberg/manifest_reader.h: ## @@ -26,13 +26,15 @@ #include #include "iceberg/file_reader.h" +#include "iceberg/iceberg_export.h" +#include "iceberg/type_fwd

Re: [PR] feat: add manifest related structures [iceberg-cpp]

zhjwpku commented on code in PR #91: URL: https://github.com/apache/iceberg-cpp/pull/91#discussion_r2083021722 ## src/iceberg/manifest_entry.h: ## @@ -0,0 +1,256 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. Se

Re: [PR] feat: add manifest related structures [iceberg-cpp]

zhjwpku commented on code in PR #91: URL: https://github.com/apache/iceberg-cpp/pull/91#discussion_r2083010628 ## src/iceberg/manifest_list.h: ## @@ -0,0 +1,202 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] feat: add manifest related structures [iceberg-cpp]

zhjwpku commented on code in PR #91: URL: https://github.com/apache/iceberg-cpp/pull/91#discussion_r2083003103 ## src/iceberg/manifest_entry.cc: ## @@ -0,0 +1,159 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. S

Re: [PR] feat: add manifest related structures [iceberg-cpp]

zhjwpku commented on code in PR #91: URL: https://github.com/apache/iceberg-cpp/pull/91#discussion_r2083002985 ## src/iceberg/manifest_entry.h: ## @@ -0,0 +1,256 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. Se

Re: [PR] feat: add manifest related structures [iceberg-cpp]

gty404 commented on code in PR #91: URL: https://github.com/apache/iceberg-cpp/pull/91#discussion_r2082931928 ## src/iceberg/manifest_list.cc: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] feat: add manifest related structures [iceberg-cpp]

zhjwpku commented on code in PR #91: URL: https://github.com/apache/iceberg-cpp/pull/91#discussion_r2082813643 ## src/iceberg/manifest_list.h: ## @@ -0,0 +1,202 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] feat: add manifest related structures [iceberg-cpp]

zhjwpku commented on code in PR #91: URL: https://github.com/apache/iceberg-cpp/pull/91#discussion_r2082810322 ## src/iceberg/manifest_reader.h: ## @@ -26,13 +26,15 @@ #include #include "iceberg/file_reader.h" +#include "iceberg/iceberg_export.h" +#include "iceberg/type_fwd

Re: [PR] feat: add manifest related structures [iceberg-cpp]

zhjwpku commented on code in PR #91: URL: https://github.com/apache/iceberg-cpp/pull/91#discussion_r2082809860 ## src/iceberg/manifest_reader.h: ## @@ -26,13 +26,15 @@ #include #include "iceberg/file_reader.h" +#include "iceberg/iceberg_export.h" +#include "iceberg/type_fwd

Re: [PR] feat: add manifest related structures [iceberg-cpp]

wgtmac commented on code in PR #91: URL: https://github.com/apache/iceberg-cpp/pull/91#discussion_r2079944001 ## src/iceberg/manifest_reader.h: ## @@ -26,13 +26,15 @@ #include #include "iceberg/file_reader.h" +#include "iceberg/iceberg_export.h" +#include "iceberg/type_fwd.

Re: [PR] feat: add manifest related structures [iceberg-cpp]

wgtmac commented on code in PR #91: URL: https://github.com/apache/iceberg-cpp/pull/91#discussion_r2075041940 ## src/iceberg/manifest_reader.h: ## @@ -26,13 +26,15 @@ #include #include "iceberg/file_reader.h" +#include "iceberg/iceberg_export.h" +#include "iceberg/type_fwd.

Re: [PR] feat: add manifest related structures [iceberg-cpp]

zhjwpku commented on code in PR #91: URL: https://github.com/apache/iceberg-cpp/pull/91#discussion_r2077596434 ## src/iceberg/manifest_reader.h: ## @@ -26,13 +26,15 @@ #include #include "iceberg/file_reader.h" +#include "iceberg/iceberg_export.h" +#include "iceberg/type_fwd

Re: [PR] feat: add manifest related structures [iceberg-cpp]

zhjwpku commented on code in PR #91: URL: https://github.com/apache/iceberg-cpp/pull/91#discussion_r2077613787 ## src/iceberg/manifest_list.h: ## @@ -0,0 +1,203 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] feat: add manifest related structures [iceberg-cpp]

zhjwpku commented on code in PR #91: URL: https://github.com/apache/iceberg-cpp/pull/91#discussion_r2077602645 ## src/iceberg/manifest_list.cc: ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. Se

[PR] feat: add manifest related structures [iceberg-cpp]

zhjwpku opened a new pull request, #91: URL: https://github.com/apache/iceberg-cpp/pull/91 Add DataFile, ManifestEntry, ManifestFile, and ManifestList to Iceberg core. Support for parsing these data structures from Avro file will be added in future PRs. -- This is an automated message