wgtmac commented on code in PR #91:
URL: https://github.com/apache/iceberg-cpp/pull/91#discussion_r2085835400
##########
src/iceberg/schema_field.h:
##########
@@ -86,4 +86,16 @@ class ICEBERG_EXPORT SchemaField : public
iceberg::util::Formattable {
bool optional_;
};
+template <typename T, typename... Args>
+inline SchemaField MakeRequiredField(int id, std::string name, Args&&... args)
{
+ return SchemaField::MakeRequired(id, std::move(name),
+
std::make_shared<T>(std::forward<Args>(args)...));
+}
+
+template <typename T, typename... Args>
+inline SchemaField MakeOptionalField(int id, std::string name, Args&&... args)
{
Review Comment:
```suggestion
inline SchemaField MakeOptionalField(int32_t id, std::string name, Args&&...
args) {
```
##########
src/iceberg/schema_field.h:
##########
@@ -86,4 +86,16 @@ class ICEBERG_EXPORT SchemaField : public
iceberg::util::Formattable {
bool optional_;
};
+template <typename T, typename... Args>
+inline SchemaField MakeRequiredField(int id, std::string name, Args&&... args)
{
Review Comment:
```suggestion
inline SchemaField MakeRequiredField(int32_t id, std::string name, Args&&...
args) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
