Xuanwo merged PR #65:
URL: https://github.com/apache/iceberg-cpp/pull/65
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac
wgtmac commented on code in PR #65:
URL: https://github.com/apache/iceberg-cpp/pull/65#discussion_r2036568131
##
src/iceberg/util/macro_internal.h:
##
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.
zhjwpku commented on code in PR #65:
URL: https://github.com/apache/iceberg-cpp/pull/65#discussion_r2036560556
##
src/iceberg/util/macro_internal.h:
##
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.
wgtmac commented on PR #65:
URL: https://github.com/apache/iceberg-cpp/pull/65#issuecomment-2791580017
Thanks @gty404 for the review!
@lidavidm @zhjwpku @yingcai-cy Could you help review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
wgtmac commented on code in PR #65:
URL: https://github.com/apache/iceberg-cpp/pull/65#discussion_r2036491127
##
src/iceberg/schema_internal.cc:
##
@@ -344,13 +382,254 @@ expected, Error>
FromArrowSchema(const ArrowSchema& sche
.message = "Arrow schema must be a struc
gty404 commented on code in PR #65:
URL: https://github.com/apache/iceberg-cpp/pull/65#discussion_r2036474805
##
src/iceberg/schema_internal.cc:
##
@@ -344,13 +382,254 @@ expected, Error>
FromArrowSchema(const ArrowSchema& sche
.message = "Arrow schema must be a struc
